Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add @tree-node-hover-bg and @tree-node-selected-bg less variables #18593

Merged
merged 1 commit into from Sep 3, 2019

Conversation

MrHeer
Copy link
Contributor

@MrHeer MrHeer commented Sep 1, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #18539

📝 Changelog

Language Changelog
🇺🇸 English 💄 Add @tree-node-hover-bg and @tree-node-selected-bg less variables
🇨🇳 Chinese 💄 新增 @tree-node-hover-bg 和 @tree-node-selected-bg less 变量

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Sep 1, 2019

Deploy preview for ant-design ready!

Built with commit d708aa4

https://deploy-preview-18593--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Sep 1, 2019

Codecov Report

Merging #18593 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18593   +/-   ##
=======================================
  Coverage   96.73%   96.73%           
=======================================
  Files         280      280           
  Lines        7537     7537           
  Branches     2102     2057   -45     
=======================================
  Hits         7291     7291           
  Misses        244      244           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a111e62...ab0a88e. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 1, 2019

Codecov Report

Merging #18593 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18593      +/-   ##
==========================================
- Coverage   96.78%   96.74%   -0.04%     
==========================================
  Files         281      281              
  Lines        7553     7553              
  Branches     2104     2062      -42     
==========================================
- Hits         7310     7307       -3     
- Misses        241      244       +3     
  Partials        2        2
Impacted Files Coverage Δ
components/_util/wave.tsx 85.57% <0%> (-2.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30b1ded...d708aa4. Read the comment docs.

@7Charlotte
Copy link

7Charlotte commented Sep 2, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #18539

📝 Changelog

Language Changelog
🇺🇸 English 💄 Add @tree-hover-bg and @ree-selected-bg less variables
🇨🇳 Chinese 💄 新增 @tree-hover-bg 和 @tree-selected-bg less 变量

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Hi,Heer

I wonder when will these features be released?

And by the way, are you a member of ant design team?

@MrHeer
Copy link
Contributor Author

MrHeer commented Sep 2, 2019

@7Charlotte Sorry, I'm not a member of Ant Design team.

@@ -603,6 +603,8 @@
@tree-child-padding: 18px;
@tree-directory-selected-color: #fff;
@tree-directory-selected-bg: @primary-color;
@tree-hover-bg: @item-hover-bg;
@tree-selected-bg: @primary-2;
Copy link
Contributor

@dengfuping dengfuping Sep 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The names of @tree-node-hover-bg and @tree-node-selected-bg would be better.

Copy link
Contributor Author

@MrHeer MrHeer Sep 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I'll do it right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants