Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add @tree-node-hover-bg and @tree-node-selected-bg less variables #18593

Merged
merged 1 commit into from Sep 3, 2019

Conversation

@MrHeer
Copy link
Contributor

commented Sep 1, 2019

πŸ€” This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

πŸ”— Related issue link

close #18539

πŸ“ Changelog

Language Changelog
πŸ‡ΊπŸ‡Έ English πŸ’„ Add @tree-node-hover-bg and @tree-node-selected-bg less variables
πŸ‡¨πŸ‡³ Chinese πŸ’„ ζ–°ε’ž @tree-node-hover-bg ε’Œ @tree-node-selected-bg less ε˜ι‡

β˜‘οΈ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label Sep 1, 2019

@netlify

This comment has been minimized.

Copy link

commented Sep 1, 2019

Deploy preview for ant-design ready!

Built with commit d708aa4

https://deploy-preview-18593--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Sep 1, 2019

Codecov Report

Merging #18593 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18593   +/-   ##
=======================================
  Coverage   96.73%   96.73%           
=======================================
  Files         280      280           
  Lines        7537     7537           
  Branches     2102     2057   -45     
=======================================
  Hits         7291     7291           
  Misses        244      244           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update a111e62...ab0a88e. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

commented Sep 1, 2019

Codecov Report

Merging #18593 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18593      +/-   ##
==========================================
- Coverage   96.78%   96.74%   -0.04%     
==========================================
  Files         281      281              
  Lines        7553     7553              
  Branches     2104     2062      -42     
==========================================
- Hits         7310     7307       -3     
- Misses        241      244       +3     
  Partials        2        2
Impacted Files Coverage Ξ”
components/_util/wave.tsx 85.57% <0%> (-2.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 30b1ded...d708aa4. Read the comment docs.

@7Charlotte

This comment has been minimized.

Copy link

commented Sep 2, 2019

πŸ€” This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

πŸ”— Related issue link

close #18539

πŸ“ Changelog

Language Changelog
πŸ‡ΊπŸ‡Έ English πŸ’„ Add @tree-hover-bg and @ree-selected-bg less variables
πŸ‡¨πŸ‡³ Chinese πŸ’„ ζ–°ε’ž @tree-hover-bg ε’Œ @tree-selected-bg less ε˜ι‡

β˜‘οΈ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Hi,Heer

I wonder when will these features be released?

And by the way, are you a member of ant design team?

@MrHeer

This comment has been minimized.

Copy link
Contributor Author

commented Sep 2, 2019

@7Charlotte Sorry, I'm not a member of Ant Design team.

@@ -603,6 +603,8 @@
@tree-child-padding: 18px;
@tree-directory-selected-color: #fff;
@tree-directory-selected-bg: @primary-color;
@tree-hover-bg: @item-hover-bg;
@tree-selected-bg: @primary-2;

This comment has been minimized.

Copy link
@dengfuping

dengfuping Sep 2, 2019

Member
  • The names of @tree-node-hover-bg and @tree-node-selected-bg would be better.

This comment has been minimized.

Copy link
@MrHeer

MrHeer Sep 2, 2019

Author Contributor

Thank you, I'll do it right now.

@MrHeer MrHeer force-pushed the MrHeer:add-tree-bg branch from ab0a88e to d708aa4 Sep 2, 2019

@MrHeer MrHeer changed the title feat: Add @tree-hover-bg and @tree-selected-bg less variables feat: Add @tree-node-hover-bg and @tree-node-selected-bg less variables Sep 2, 2019

@afc163 afc163 merged commit 849237b into ant-design:master Sep 3, 2019

26 of 29 checks passed

Header rules - ant-design No header rules processed
Details
LGTM analysis: JavaScript No code changes detected
Details
Pages changed - ant-design 216 new files uploaded
Details
DEP All dependencies are resolved
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 30b1ded...d708aa4
Details
codecov/project 96.74% (-0.04%) compared to 30b1ded
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Sep 3, 2019

@MrHeer MrHeer deleted the MrHeer:add-tree-bg branch Sep 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.