Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Chrome input position not align with button #18603

Merged
merged 3 commits into from Sep 2, 2019

Conversation

@zombieJ
Copy link
Member

commented Sep 2, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

ref #17082

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Input not vertical align with Button in Chrome.
🇨🇳 Chinese 修复 Chrome 中 Input 与 Button 不垂直对齐的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/input/demo/algin.md

@pr-triage pr-triage bot added the PR: unreviewed label Sep 2, 2019

@netlify

This comment has been minimized.

Copy link

commented Sep 2, 2019

Deploy preview for ant-design ready!

Built with commit be65544

https://deploy-preview-18603--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Sep 2, 2019

Codecov Report

Merging #18603 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18603      +/-   ##
==========================================
- Coverage   96.74%   96.73%   -0.01%     
==========================================
  Files         281      281              
  Lines        7553     7538      -15     
  Branches     2062     2057       -5     
==========================================
- Hits         7307     7292      -15     
  Misses        244      244              
  Partials        2        2
Impacted Files Coverage Δ
components/breadcrumb/Breadcrumb.tsx 96.66% <0%> (-0.31%) ⬇️
components/card/index.tsx 100% <0%> (ø) ⬆️
components/input-number/index.tsx 100% <0%> (ø) ⬆️
components/page-header/index.tsx 100% <0%> (ø) ⬆️
components/anchor/AnchorLink.tsx 100% <0%> (ø) ⬆️
components/card/Grid.tsx 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61e319b...be65544. Read the comment docs.

@afc163
afc163 approved these changes Sep 2, 2019

@zombieJ zombieJ merged commit cc9c658 into master Sep 2, 2019

26 of 31 checks passed

Build
Details
License Compliance Analysis done, scanning for issues...
Details
netlify/ant-design/deploy-preview Deploy preview processing.
Details
Header rules - ant-design No header rules processed
Details
LGTM analysis: JavaScript No code changes detected
Details
Pages changed - ant-design 214 new files uploaded
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No significant change
Details
bundlesize Total bundle size is 582.14KB/600KB (-null)
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 61e319b...be65544
Details
codecov/project 96.73% (-0.01%) compared to 61e319b
Details
security/snyk - package.json (paranoidjk) No new issues
Details

@zombieJ zombieJ deleted the align-again branch Sep 2, 2019

@pr-triage pr-triage bot added PR: merged and removed PR: reviewed-approved labels Sep 2, 2019

@afc163 afc163 referenced this pull request Sep 2, 2019
5 of 14 tasks complete
shaodahong added a commit to shaodahong/ant-design that referenced this pull request Sep 6, 2019
fix: Chrome input position not align with button (ant-design#18603)
* add debug

* fix: Chrome input position not align with button

* fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.