Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert "fix: Upload.Dragger should work with multiple is false" #18626

Merged
merged 1 commit into from Sep 3, 2019

Conversation

@zombieJ
Copy link
Member

commented Sep 3, 2019

Reverts #18580

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #18618

open #17397

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Upload can not upload more than one file when multiple is false.
🇨🇳 Chinese 修复 Upload 在 multiplefalse 时无法上传多于一个文件的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label Sep 3, 2019

@tests-checker
Copy link

left a comment

Could you please add tests to make sure this change works as expected?

@netlify

This comment has been minimized.

Copy link

commented Sep 3, 2019

Deploy preview for ant-design ready!

Built with commit b4c8269

https://deploy-preview-18626--ant-design.netlify.com

@afc163
afc163 approved these changes Sep 3, 2019
@codecov

This comment has been minimized.

Copy link

commented Sep 3, 2019

Codecov Report

Merging #18626 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18626      +/-   ##
==========================================
- Coverage   96.74%   96.74%   -0.01%     
==========================================
  Files         281      281              
  Lines        7553     7550       -3     
  Branches     2062     2106      +44     
==========================================
- Hits         7307     7304       -3     
  Misses        244      244              
  Partials        2        2
Impacted Files Coverage Δ
components/upload/Upload.tsx 95.45% <ø> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4a3b72...b4c8269. Read the comment docs.

@zombieJ zombieJ changed the title Revert "fix: Upload.Dragger should work with multiple is false" fix: Revert "fix: Upload.Dragger should work with multiple is false" Sep 3, 2019

@zombieJ zombieJ merged commit e5d644f into master Sep 3, 2019

28 of 32 checks passed

Build
Details
ant-design.ant-design in progress
Details
netlify/ant-design/deploy-preview Deploy preview processing.
Details
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 215 new files uploaded
Details
DEP All dependencies are resolved
LGTM analysis: JavaScript No new or fixed alerts
Details
License Compliance All checks passed.
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
buildsize No prior size to compare - 848.65 KB
Details
bundlesize Total bundle size is 582.44KB/600KB (-null)
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing e4a3b72...b4c8269
Details
codecov/project 96.74% (-0.01%) compared to e4a3b72
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@zombieJ zombieJ deleted the revert-18580-drapper-multiple branch Sep 3, 2019

@zombieJ zombieJ referenced this pull request Sep 3, 2019
shaodahong added a commit to shaodahong/ant-design that referenced this pull request Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.