Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert "fix: Upload.Dragger should work with multiple is false" #18626

Merged
merged 1 commit into from Sep 3, 2019

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Sep 3, 2019

Reverts #18580

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #18618

open #17397

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Upload can not upload more than one file when multiple is false.
🇨🇳 Chinese 修复 Upload 在 multiplefalse 时无法上传多于一个文件的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@netlify
Copy link

netlify bot commented Sep 3, 2019

Deploy preview for ant-design ready!

Built with commit b4c8269

https://deploy-preview-18626--ant-design.netlify.com

afc163
afc163 approved these changes Sep 3, 2019
@codecov
Copy link

codecov bot commented Sep 3, 2019

Codecov Report

Merging #18626 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18626      +/-   ##
==========================================
- Coverage   96.74%   96.74%   -0.01%     
==========================================
  Files         281      281              
  Lines        7553     7550       -3     
  Branches     2062     2106      +44     
==========================================
- Hits         7307     7304       -3     
  Misses        244      244              
  Partials        2        2
Impacted Files Coverage Δ
components/upload/Upload.tsx 95.45% <ø> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4a3b72...b4c8269. Read the comment docs.

@zombieJ zombieJ changed the title Revert "fix: Upload.Dragger should work with multiple is false" fix: Revert "fix: Upload.Dragger should work with multiple is false" Sep 3, 2019
@zombieJ zombieJ merged commit e5d644f into master Sep 3, 2019
23 of 25 checks passed
@zombieJ zombieJ deleted the revert-18580-drapper-multiple branch Sep 3, 2019
@zombieJ zombieJ mentioned this pull request Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload component can't upload more than 1 file
2 participants