Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: warning if user use inputValue in Select #18629

Merged
merged 2 commits into from Sep 3, 2019

Conversation

@zombieJ
Copy link
Member

commented Sep 3, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

ref #18584

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Deprecated Select inputValue prop and use searchValue instead.
🇨🇳 Chinese 废弃 Select inputValue 属性并提供 searchValue 作为替换。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/select/index.en-US.md
View rendered components/select/index.zh-CN.md

zombieJ added 2 commits Sep 3, 2019

@pr-triage pr-triage bot added the PR: unreviewed label Sep 3, 2019

@tests-checker
Copy link

left a comment

Could you please add tests to make sure this change works as expected?

@zombieJ zombieJ requested a review from afc163 Sep 3, 2019

@netlify

This comment has been minimized.

Copy link

commented Sep 3, 2019

Deploy preview for ant-design ready!

Built with commit 726de28

https://deploy-preview-18629--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Sep 3, 2019

Codecov Report

Merging #18629 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18629      +/-   ##
==========================================
+ Coverage   96.74%   96.74%   +<.01%     
==========================================
  Files         281      281              
  Lines        7550     7552       +2     
  Branches     2103     2107       +4     
==========================================
+ Hits         7304     7306       +2     
  Misses        244      244              
  Partials        2        2
Impacted Files Coverage Δ
components/select/index.tsx 96.96% <100%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0466900...726de28. Read the comment docs.

@afc163

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

image

英文文档里有这个属性。

@afc163 afc163 merged commit aa9b9db into master Sep 3, 2019

30 of 32 checks passed

Build
Details
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 215 new files uploaded
Details
DEP All dependencies are resolved
LGTM analysis: JavaScript No new or fixed alerts
Details
License Compliance All checks passed.
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
bundlesize Total bundle size is 582.5KB/600KB (-null)
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 96.74%)
Details
codecov/project 96.74% (+<.01%) compared to 0466900
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@afc163 afc163 deleted the deprecated branch Sep 3, 2019

@afc163

This comment has been minimized.

Copy link
Member

commented Sep 17, 2019

无论是 inputValue 还是 searchValue 貌似都不生效。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.