Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: warning if user use inputValue in Select #18629

Merged
merged 2 commits into from Sep 3, 2019
Merged

chore: warning if user use inputValue in Select #18629

merged 2 commits into from Sep 3, 2019

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Sep 3, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

ref #18584

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Deprecated Select inputValue prop and use searchValue instead.
🇨🇳 Chinese 废弃 Select inputValue 属性并提供 searchValue 作为替换。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/select/index.en-US.md
View rendered components/select/index.zh-CN.md

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@netlify
Copy link

netlify bot commented Sep 3, 2019

Deploy preview for ant-design ready!

Built with commit 726de28

https://deploy-preview-18629--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Sep 3, 2019

Codecov Report

Merging #18629 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18629      +/-   ##
==========================================
+ Coverage   96.74%   96.74%   +<.01%     
==========================================
  Files         281      281              
  Lines        7550     7552       +2     
  Branches     2103     2107       +4     
==========================================
+ Hits         7304     7306       +2     
  Misses        244      244              
  Partials        2        2
Impacted Files Coverage Δ
components/select/index.tsx 96.96% <100%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0466900...726de28. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Sep 3, 2019

image

英文文档里有这个属性。

@afc163 afc163 merged commit aa9b9db into master Sep 3, 2019
25 checks passed
@afc163 afc163 deleted the deprecated branch Sep 3, 2019
@afc163
Copy link
Member

afc163 commented Sep 17, 2019

无论是 inputValue 还是 searchValue 貌似都不生效。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants