Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #18607 #18636

Merged
merged 1 commit into from Sep 3, 2019

Conversation

@jljsj33
Copy link
Member

commented Sep 3, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese 修复抽屉渲染在当前且 mask 为 false 时的动画问题

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@jljsj33 jljsj33 requested a review from afc163 Sep 3, 2019

@pr-triage pr-triage bot added the PR: unreviewed label Sep 3, 2019

@netlify

This comment has been minimized.

Copy link

commented Sep 3, 2019

Deploy preview for ant-design ready!

Built with commit b075a39

https://deploy-preview-18636--ant-design.netlify.com

@jljsj33 jljsj33 changed the title fix #18607 fix: #18607 Sep 3, 2019

@jljsj33

This comment has been minimized.

Copy link
Member Author

commented Sep 3, 2019

这种方法可以修复那问题,但就是丑了点,,@afc163

@codecov

This comment has been minimized.

Copy link

commented Sep 3, 2019

Codecov Report

Merging #18636 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18636   +/-   ##
=======================================
  Coverage   96.74%   96.74%           
=======================================
  Files         281      281           
  Lines        7552     7552           
  Branches     2062     2104   +42     
=======================================
  Hits         7306     7306           
  Misses        244      244           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa9b9db...b075a39. Read the comment docs.

@afc163 afc163 merged commit 3ad0e80 into master Sep 3, 2019

28 of 32 checks passed

Build
Details
License Compliance FOSSA is analyzing this commit
Details
Header rules - ant-design No header rules processed
Details
LGTM analysis: JavaScript No code changes detected
Details
Pages changed - ant-design 217 new files uploaded
Details
DEP All dependencies are resolved
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
bundlesize Total bundle size is 582.54KB/600KB (-null)
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing aa9b9db...b075a39
Details
codecov/project 96.74% remains the same compared to aa9b9db
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@afc163 afc163 deleted the drawer-no-mask branch Sep 3, 2019

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Sep 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.