Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Anchor.Link target should not be required #18646

Merged
merged 1 commit into from Sep 3, 2019

Conversation

@yutingzhao1991
Copy link
Contributor

commented Sep 3, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix issue in pr https://github.com/ant-design/ant-design/pull/18335/files

💡 Background and solution

Anchor.Link target should not be required

📝 Changelog

Language Changelog
🇺🇸 English fix: Anchor.Link target prop should not be required
🇨🇳 Chinese fix: Anchor.Link 的 target 属性不应该是必须的

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label Sep 3, 2019

@netlify

This comment has been minimized.

Copy link

commented Sep 3, 2019

Deploy preview for ant-design ready!

Built with commit 0b0e331

https://deploy-preview-18646--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Sep 3, 2019

Codecov Report

Merging #18646 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18646   +/-   ##
=======================================
  Coverage   96.74%   96.74%           
=======================================
  Files         281      281           
  Lines        7552     7552           
  Branches     2062     2104   +42     
=======================================
  Hits         7306     7306           
  Misses        244      244           
  Partials        2        2
Impacted Files Coverage Δ
components/anchor/AnchorLink.tsx 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7864ab4...0b0e331. Read the comment docs.

@afc163 afc163 merged commit d8031aa into master Sep 3, 2019

29 of 32 checks passed

Build
Details
License Compliance FOSSA is analyzing this commit
Details
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 215 new files uploaded
Details
DEP All dependencies are resolved
LGTM analysis: JavaScript No new or fixed alerts
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No prior size to compare - 848.68 KB
Details
bundlesize Total bundle size is 582.54KB/600KB (-null)
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 7864ab4...0b0e331
Details
codecov/project 96.74% remains the same compared to 7864ab4
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@afc163 afc163 deleted the fix/linktarget branch Sep 3, 2019

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Sep 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.