Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Anchor.Link target should not be required #18646

Merged
merged 1 commit into from Sep 3, 2019
Merged

Conversation

yutingzhao1991
Copy link
Contributor

@yutingzhao1991 yutingzhao1991 commented Sep 3, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix issue in pr https://github.com/ant-design/ant-design/pull/18335/files

💡 Background and solution

Anchor.Link target should not be required

📝 Changelog

Language Changelog
🇺🇸 English fix: Anchor.Link target prop should not be required
🇨🇳 Chinese fix: Anchor.Link 的 target 属性不应该是必须的

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Sep 3, 2019

Deploy preview for ant-design ready!

Built with commit 0b0e331

https://deploy-preview-18646--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Sep 3, 2019

Codecov Report

Merging #18646 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18646   +/-   ##
=======================================
  Coverage   96.74%   96.74%           
=======================================
  Files         281      281           
  Lines        7552     7552           
  Branches     2062     2104   +42     
=======================================
  Hits         7306     7306           
  Misses        244      244           
  Partials        2        2
Impacted Files Coverage Δ
components/anchor/AnchorLink.tsx 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7864ab4...0b0e331. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants