Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PageHeader): Allow back icon to coexist with breadcrumb #18691

Merged
merged 1 commit into from Sep 6, 2019

Conversation

@dengfuping
Copy link
Member

commented Sep 5, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

  • According to the latest design, it's allowed that back icon coexists with breadcrumb.
    image

📝 Changelog

Language Changelog
🇺🇸 English 🐞 Fix PageHeader that back icon can't coexist with breadcrumb. #18094
🇨🇳 Chinese 🐞 修复 PageHeader 中返回图标与面包屑无法共存的问题。#18094

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@dengfuping dengfuping requested review from afc163 and chenshuai2144 Sep 5, 2019

@pr-triage pr-triage bot added the PR: unreviewed label Sep 5, 2019

@netlify

This comment has been minimized.

Copy link

commented Sep 5, 2019

Deploy preview for ant-design ready!

Built with commit 28b61a3

https://deploy-preview-18691--ant-design.netlify.com

@lgtm-com

This comment has been minimized.

Copy link

commented Sep 5, 2019

This pull request introduces 1 alert when merging a016016 into e479f1f - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class
@afc163

This comment has been minimized.

Copy link
Member

commented Sep 5, 2019

ci broken

@dengfuping dengfuping force-pushed the tabs-onBack-breadcrumb branch from a016016 to 705424b Sep 6, 2019

@dengfuping dengfuping force-pushed the tabs-onBack-breadcrumb branch from 705424b to 28b61a3 Sep 6, 2019

@codecov

This comment has been minimized.

Copy link

commented Sep 6, 2019

Codecov Report

Merging #18691 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18691      +/-   ##
==========================================
- Coverage   96.78%   96.77%   -0.01%     
==========================================
  Files         281      281              
  Lines        7552     7543       -9     
  Branches     2103     2101       -2     
==========================================
- Hits         7309     7300       -9     
  Misses        241      241              
  Partials        2        2
Impacted Files Coverage Δ
components/page-header/index.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8641383...28b61a3. Read the comment docs.

@afc163
afc163 approved these changes Sep 6, 2019

@dengfuping dengfuping merged commit ffe0645 into master Sep 6, 2019

29 of 31 checks passed

Build
Details
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 215 new files uploaded
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
License Compliance All checks passed.
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
bundlesize Total bundle size is 582.53KB/600KB (-null)
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 96.78%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +3.21% compared to 8641383
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@dengfuping dengfuping deleted the tabs-onBack-breadcrumb branch Sep 6, 2019

@pr-triage pr-triage bot added PR: merged and removed PR: reviewed-approved labels Sep 6, 2019

@chenshuai2144 chenshuai2144 referenced this pull request Sep 12, 2019
5 of 14 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.