Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: link button should not insert space #18724

Merged
merged 3 commits into from Sep 7, 2019

Conversation

@afc163
Copy link
Member

commented Sep 7, 2019

πŸ€” This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

πŸ”— Related issue link

close #18118

πŸ’‘ Background and solution

πŸ“ Changelog

Language Changelog
πŸ‡ΊπŸ‡Έ English Button type="link" should not insert space.
πŸ‡¨πŸ‡³ Chinese link η±»εž‹ηš„ Button 不再插ε…₯空格。

β˜‘οΈ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
close #18118
@pr-triage pr-triage bot added the PR: unreviewed label Sep 7, 2019
Copy link

left a comment

Could you please add tests to make sure this change works as expected?

@netlify

This comment has been minimized.

Copy link

commented Sep 7, 2019

Deploy preview for ant-design ready!

Built with commit d1538a4

https://deploy-preview-18724--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Sep 7, 2019

Codecov Report

Merging #18724 into master will increase coverage by 0.17%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18724      +/-   ##
==========================================
+ Coverage   96.73%    96.9%   +0.17%     
==========================================
  Files         281      281              
  Lines        7543     7540       -3     
  Branches     2101     2103       +2     
==========================================
+ Hits         7297     7307      +10     
+ Misses        244      231      -13     
  Partials        2        2
Impacted Files Coverage Ξ”
components/button/button.tsx 100% <100%> (+6.03%) ⬆️
components/_util/wave.tsx 88.46% <0%> (+2.88%) ⬆️
components/button/button-group.tsx 100% <0%> (+17.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update cf97324...d1538a4. Read the comment docs.

@afc163 afc163 force-pushed the fix-link-button branch from 5c3b917 to 3b01e07 Sep 7, 2019
@MrHeer
MrHeer approved these changes Sep 7, 2019
@afc163 afc163 merged commit 1903ae0 into master Sep 7, 2019
29 of 31 checks passed
29 of 31 checks passed
Build
Details
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 215 new files uploaded
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
License Compliance All checks passed.
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
bundlesize Total bundle size is 582.59KB/600KB (-null)
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 96.73%)
Details
codecov/project 96.9% (+0.17%) compared to cf97324
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
@afc163 afc163 deleted the fix-link-button branch Sep 7, 2019
@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.