Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ConfigProvider locale not working with Modal in some situation #18732

Merged
merged 1 commit into from Sep 9, 2019

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Sep 9, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #18731

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix ConfigProvider locale not working with Modal in some situation.
🇨🇳 Chinese 修复 ConfigProvider locale 国际化在某些场景下对 Modal 不生效的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@netlify
Copy link

netlify bot commented Sep 9, 2019

Deploy preview for ant-design ready!

Built with commit 0effe96

https://deploy-preview-18732--ant-design.netlify.com

@@ -73,8 +73,8 @@ export default class LocaleProvider extends React.Component<LocaleProviderProps,
const { locale } = this.props;
if (prevProps.locale !== locale) {
setMomentLocale(locale);
changeConfirmLocale(locale && locale.Modal);
Copy link
Member Author

@afc163 afc163 Sep 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还是需要判断一下是否变化。

@codecov
Copy link

codecov bot commented Sep 9, 2019

Codecov Report

Merging #18732 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18732   +/-   ##
=======================================
  Coverage    96.9%    96.9%           
=======================================
  Files         281      281           
  Lines        7540     7540           
  Branches     2058     2100   +42     
=======================================
  Hits         7307     7307           
  Misses        231      231           
  Partials        2        2
Impacted Files Coverage Δ
components/locale-provider/index.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3ac730...0effe96. Read the comment docs.

yoyo837
yoyo837 approved these changes Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants