Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: number controls overlap borders when active #18791

Merged

Conversation

@escorponox
Copy link

commented Sep 12, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

fix #18790

馃挕 Background and solution

Input border is overlapped by the control spans. Added the needed border-radius to the spans.

image

image

Fixed demo:
https://codesandbox.io/s/compassionate-shape-pe2th

馃摑 Changelog

Neither changes from userside, nor potential break changes or other risks.

Language Changelog
馃嚭馃嚫 English
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@pr-triage pr-triage bot added the PR: unreviewed label Sep 12, 2019
@netlify

This comment has been minimized.

Copy link

commented Sep 12, 2019

Deploy preview for ant-design ready!

Built with commit 562d87c

https://deploy-preview-18791--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Sep 12, 2019

Codecov Report

Merging #18791 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18791   +/-   ##
=======================================
  Coverage    96.9%    96.9%           
=======================================
  Files         281      281           
  Lines        7540     7540           
  Branches     2100     2100           
=======================================
  Hits         7307     7307           
  Misses        231      231           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update b786e6b...562d87c. Read the comment docs.

2 similar comments
@codecov

This comment has been minimized.

Copy link

commented Sep 12, 2019

Codecov Report

Merging #18791 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18791   +/-   ##
=======================================
  Coverage    96.9%    96.9%           
=======================================
  Files         281      281           
  Lines        7540     7540           
  Branches     2100     2100           
=======================================
  Hits         7307     7307           
  Misses        231      231           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update b786e6b...562d87c. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

commented Sep 12, 2019

Codecov Report

Merging #18791 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18791   +/-   ##
=======================================
  Coverage    96.9%    96.9%           
=======================================
  Files         281      281           
  Lines        7540     7540           
  Branches     2100     2100           
=======================================
  Hits         7307     7307           
  Misses        231      231           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update b786e6b...562d87c. Read the comment docs.

@yoyo837

This comment has been minimized.

Copy link
Collaborator

commented Sep 12, 2019

image

@afc163 afc163 changed the title Fix number controls overlap borders when active fix: number controls overlap borders when active Sep 12, 2019
@afc163 afc163 merged commit 98dfd2a into ant-design:master Sep 12, 2019
25 of 28 checks passed
25 of 28 checks passed
Header rules - ant-design No header rules processed
Details
LGTM analysis: JavaScript No code changes detected
Details
Pages changed - ant-design 217 new files uploaded
Details
DEP All dependencies are resolved
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing b786e6b...562d87c
Details
codecov/project 96.9% remains the same compared to b786e6b
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.