Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: small table headers missing border #18821

Merged
merged 1 commit into from Sep 17, 2019

Conversation

@afc163
Copy link
Member

commented Sep 16, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #18762

💡 Background and solution

image

fixed to

image

📝 Changelog

Language Changelog
🇺🇸 English Fix size="small" Table header missing right border.
🇨🇳 Chinese 修复 Table size="small" 时丢失列头右边框的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
close #18762
@pr-triage pr-triage bot added the PR: unreviewed label Sep 16, 2019
@netlify

This comment has been minimized.

Copy link

commented Sep 16, 2019

Deploy preview for ant-design ready!

Built with commit b935db8

https://deploy-preview-18821--ant-design.netlify.com

@afc163 afc163 referenced this pull request Sep 16, 2019
@codecov

This comment has been minimized.

Copy link

commented Sep 16, 2019

Codecov Report

Merging #18821 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18821   +/-   ##
=======================================
  Coverage   96.91%   96.91%           
=======================================
  Files         281      281           
  Lines        7546     7546           
  Branches     2102     2102           
=======================================
  Hits         7313     7313           
  Misses        231      231           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc81c13...b935db8. Read the comment docs.

@MrHeer
MrHeer approved these changes Sep 16, 2019
@ycjcl868 ycjcl868 merged commit 81e6f50 into master Sep 17, 2019
28 of 31 checks passed
28 of 31 checks passed
Build
Details
Header rules - ant-design No header rules processed
Details
LGTM analysis: JavaScript No code changes detected
Details
Pages changed - ant-design 219 new files uploaded
Details
DEP All dependencies are resolved
License Compliance All checks passed.
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
buildsize No prior size to compare - 846.84 KB
Details
bundlesize Total bundle size is 582.65KB/600KB (-null)
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing fc81c13...b935db8
Details
codecov/project 96.91% remains the same compared to fc81c13
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
@ycjcl868 ycjcl868 deleted the fix-table-border-style branch Sep 17, 2019
@afc163 afc163 referenced this pull request Sep 17, 2019
0 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.