Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tree switcherIcon prop not working when showLine #18829

Merged
merged 2 commits into from Sep 23, 2019

Conversation

MrHeer
Copy link
Contributor

@MrHeer MrHeer commented Sep 16, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #18810

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English 🐛 Fix Tree switcherIcon prop not working when showLine is true
🇨🇳 Chinese 🐛 修修复当 showLine 设置后 Tree 组件的 switcherIcon 属性没有正常工作

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Sep 16, 2019

Deploy preview for ant-design ready!

Built with commit d903b7c

https://deploy-preview-18829--ant-design.netlify.com

@afc163
Copy link
Member

afc163 commented Sep 16, 2019

来个用例?

@afc163
Copy link
Member

afc163 commented Sep 16, 2019

close #18717 too

@MrHeer
Copy link
Contributor Author

MrHeer commented Sep 16, 2019

I just fix this bug, no feature for #18717

@codecov
Copy link

codecov bot commented Sep 16, 2019

Codecov Report

Merging #18829 into master will decrease coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18829      +/-   ##
==========================================
- Coverage   96.91%   96.88%   -0.03%     
==========================================
  Files         281      281              
  Lines        7546     7546              
  Branches     2102     2105       +3     
==========================================
- Hits         7313     7311       -2     
- Misses        231      233       +2     
  Partials        2        2
Impacted Files Coverage Δ
components/tree/Tree.tsx 90.62% <66.66%> (-6.25%) ⬇️
components/_util/responsiveObserve.ts 100% <0%> (ø) ⬆️
components/layout/Sider.tsx 95.6% <0%> (ø) ⬆️
components/carousel/index.tsx 96.55% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe30adc...d903b7c. Read the comment docs.

@ywy94ywy
Copy link

ywy94ywy commented Sep 19, 2019

修复了吗?我什么我还是无法更改,我希望是这样子的

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants