Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix #18848 #18849

Merged
merged 2 commits into from Sep 17, 2019

Conversation

@kagawagao
Copy link
Contributor

commented Sep 17, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

#18848

馃挕 Background and solution

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@pr-triage pr-triage bot added the PR: unreviewed label Sep 17, 2019
@netlify

This comment has been minimized.

Copy link

commented Sep 17, 2019

Deploy preview for ant-design ready!

Built with commit ff6056a

https://deploy-preview-18849--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Sep 17, 2019

Codecov Report

Merging #18849 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18849      +/-   ##
==========================================
+ Coverage   96.91%   96.91%   +<.01%     
==========================================
  Files         281      281              
  Lines        7546     7547       +1     
  Branches     2102     2103       +1     
==========================================
+ Hits         7313     7314       +1     
  Misses        231      231              
  Partials        2        2
Impacted Files Coverage 螖
components/transfer/renderListBody.tsx 90.62% <100%> (+0.3%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 1acd7e2...ff6056a. Read the comment docs.

@zombieJ zombieJ merged commit 7404a7e into ant-design:master Sep 17, 2019
25 of 27 checks passed
25 of 27 checks passed
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 217 new files uploaded
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
buildsize No change
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 96.91%)
Details
codecov/project 96.91% (+<.01%) compared to 1acd7e2
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No new issues
Details
@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Sep 17, 2019
@kagawagao kagawagao deleted the kagawagao:fix-transfer-disabled branch Sep 17, 2019
@zombieJ zombieJ referenced this pull request Sep 21, 2019
1 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.