Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Input addonAfter icon height bug in Chrome #18858

Merged
merged 1 commit into from Sep 17, 2019

Conversation

@afc163
Copy link
Member

commented Sep 17, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #18857
close #18856

💡 Background and solution

image

📝 Changelog

Language Changelog
🇺🇸 English 修复 Input addonAfter 里图标高度在 Chrome 下偏大的问题。
🇨🇳 Chinese Fix Input addonAfter icon height bug in Chrome

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@pr-triage pr-triage bot added the PR: unreviewed label Sep 17, 2019
@netlify

This comment has been minimized.

Copy link

commented Sep 17, 2019

Deploy preview for ant-design ready!

Built with commit 08fff9d

https://deploy-preview-18858--ant-design.netlify.com

@afc163 afc163 changed the title fix: Input.Group icon height bug in Chrome fix: Input addonAfter icon height bug in Chrome Sep 17, 2019
@afc163 afc163 merged commit b188a5e into master Sep 17, 2019
10 of 22 checks passed
10 of 22 checks passed
Build
Details
License Compliance FOSSA is analyzing this commit
Details
ci/circleci: compile CircleCI is running your tests
Details
ci/circleci: dist CircleCI is running your tests
Details
ci/circleci: lint Your tests are queued behind your running builds
Details
ci/circleci: test_dom Your tests are queued behind your running builds
Details
ci/circleci: test_dom_15 Your tests are queued behind your running builds
Details
ci/circleci: test_node CircleCI is running your tests
Details
ci/circleci: test_node_15 CircleCI is running your tests
Details
netlify/ant-design/deploy-preview Deploy preview processing.
Details
Header rules - ant-design No header rules processed
Details
LGTM analysis: JavaScript No code changes detected
Details
Pages changed - ant-design 217 new files uploaded
Details
DEP All dependencies are resolved
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
buildsize No change
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
@afc163 afc163 deleted the fix-addon-height branch Sep 17, 2019
@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Sep 17, 2019
@zombieJ zombieJ referenced this pull request Sep 21, 2019
1 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.