Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disabled input should not trigger the action of suffix part #18889 #18900

Merged
merged 1 commit into from Sep 20, 2019

Conversation

@dilidili
Copy link
Contributor

commented Sep 19, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #18889

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Disabled input should not trigger the action of suffix part
🇨🇳 Chinese 失效状态的 Input 的后缀图标应不可点击

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@pr-triage pr-triage bot added the PR: unreviewed label Sep 19, 2019
@netlify

This comment has been minimized.

Copy link

commented Sep 19, 2019

Deploy preview for ant-design ready!

Built with commit bad2de2

https://deploy-preview-18900--ant-design.netlify.com

@afc163

This comment has been minimized.

Copy link
Member

commented Sep 19, 2019

来个用例如何?

@dilidili dilidili force-pushed the dilidili:fix-disabled-search branch from e986f66 to b43d4d9 Sep 19, 2019
@codecov

This comment has been minimized.

Copy link

commented Sep 19, 2019

Codecov Report

Merging #18900 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18900      +/-   ##
==========================================
- Coverage   96.92%   96.91%   -0.02%     
==========================================
  Files         281      281              
  Lines        7548     7554       +6     
  Branches     2106     2105       -1     
==========================================
+ Hits         7316     7321       +5     
- Misses        230      231       +1     
  Partials        2        2
Impacted Files Coverage Δ
components/input/Search.tsx 100% <100%> (ø) ⬆️
components/input/Password.tsx 100% <100%> (ø) ⬆️
components/menu/index.tsx 97.5% <0%> (-0.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 974fb1b...bad2de2. Read the comment docs.

@dilidili

This comment has been minimized.

Copy link
Contributor Author

commented Sep 19, 2019

来个用例如何?

好了加上了

@yoyo837

This comment has been minimized.

Copy link
Collaborator

commented Sep 19, 2019

用例的react/jsx-boolean-value 处理下

@dilidili dilidili force-pushed the dilidili:fix-disabled-search branch from b43d4d9 to bad2de2 Sep 20, 2019
@afc163 afc163 merged commit 1d8c6f8 into ant-design:master Sep 20, 2019
25 of 27 checks passed
25 of 27 checks passed
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 218 new files uploaded
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
buildsize No change
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 96.92%)
Details
codecov/project Absolute coverage decreased by -0.01% but relative coverage increased by +3.07% compared to 974fb1b
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Sep 20, 2019
@zombieJ zombieJ referenced this pull request Sep 21, 2019
1 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.