Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disabled input should not trigger the action of suffix part #18889 #18900

Merged
merged 1 commit into from Sep 20, 2019

Conversation

dilidili
Copy link
Contributor

@dilidili dilidili commented Sep 19, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #18889

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Disabled input should not trigger the action of suffix part
🇨🇳 Chinese 失效状态的 Input 的后缀图标应不可点击

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Sep 19, 2019

Deploy preview for ant-design ready!

Built with commit bad2de2

https://deploy-preview-18900--ant-design.netlify.com

@afc163
Copy link
Member

afc163 commented Sep 19, 2019

来个用例如何?

@codecov
Copy link

codecov bot commented Sep 19, 2019

Codecov Report

Merging #18900 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18900      +/-   ##
==========================================
- Coverage   96.92%   96.91%   -0.02%     
==========================================
  Files         281      281              
  Lines        7548     7554       +6     
  Branches     2106     2105       -1     
==========================================
+ Hits         7316     7321       +5     
- Misses        230      231       +1     
  Partials        2        2
Impacted Files Coverage Δ
components/input/Search.tsx 100% <100%> (ø) ⬆️
components/input/Password.tsx 100% <100%> (ø) ⬆️
components/menu/index.tsx 97.5% <0%> (-0.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 974fb1b...bad2de2. Read the comment docs.

@dilidili
Copy link
Contributor Author

dilidili commented Sep 19, 2019

来个用例如何?

好了加上了

@yoyo837
Copy link
Contributor

yoyo837 commented Sep 19, 2019

用例的react/jsx-boolean-value 处理下

@JounQin
Copy link
Contributor

JounQin commented Jun 7, 2022

Password 类型 disabled 状态是否应该可以切换可见性,还是应该用 readOnly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants