Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Menu lost state when collapsedWidth is 0 #18907

Merged
merged 2 commits into from Sep 19, 2019

Conversation

@afc163
Copy link
Member

commented Sep 19, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #18825

related issue #8587

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Menu lost state when being collapsed to 0px.
🇨🇳 Chinese 修复 Menu 当 collapsedWidth={0} 折叠时丢失 selectedKeys 状态的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
afc163 added 2 commits Sep 19, 2019
close #18825
@pr-triage pr-triage bot added the PR: unreviewed label Sep 19, 2019
Copy link

left a comment

Could you please add tests to make sure this change works as expected?

@netlify

This comment has been minimized.

Copy link

commented Sep 19, 2019

Deploy preview for ant-design ready!

Built with commit d0f15e6

https://deploy-preview-18907--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Sep 19, 2019

Codecov Report

Merging #18907 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18907      +/-   ##
==========================================
+ Coverage   96.91%   96.92%   +0.01%     
==========================================
  Files         281      281              
  Lines        7548     7548              
  Branches     2061     2103      +42     
==========================================
+ Hits         7315     7316       +1     
+ Misses        231      230       -1     
  Partials        2        2
Impacted Files Coverage Δ
components/menu/index.tsx 98.33% <100%> (+0.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca6e2f3...d0f15e6. Read the comment docs.

@afc163 afc163 merged commit 974fb1b into master Sep 19, 2019
29 of 31 checks passed
29 of 31 checks passed
Build
Details
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 217 new files uploaded
Details
DEP All dependencies are resolved
LGTM analysis: JavaScript No new or fixed alerts
Details
License Compliance All checks passed.
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
buildsize No prior size to compare - 848.06 KB
Details
bundlesize Total bundle size is 582.74KB/600KB (-null)
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 96.91%)
Details
codecov/project 96.92% (+0.01%) compared to ca6e2f3
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
@afc163 afc163 deleted the fix-menu-state branch Sep 19, 2019
@zombieJ zombieJ referenced this pull request Sep 21, 2019
1 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.