Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Breadcrumb support data against #18941

Merged
merged 8 commits into from Sep 23, 2019
Merged

feat: Breadcrumb support data against #18941

merged 8 commits into from Sep 23, 2019

Conversation

sosohime
Copy link
Contributor

@sosohime sosohime commented Sep 22, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#18350

💡 Background and solution

Breadcrumb 支持传入自定义 attribute

📝 Changelog

Language Changelog
🇺🇸 English Breadcrumb support data-* and aria-* attributes
🇨🇳 Chinese Breadcrumb 支持 data-* and aria-* 属性

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@netlify
Copy link

netlify bot commented Sep 22, 2019

Deploy preview for ant-design ready!

Built with commit 21a6d8f

https://deploy-preview-18941--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Sep 22, 2019

Codecov Report

Merging #18941 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18941   +/-   ##
=======================================
  Coverage   96.92%   96.92%           
=======================================
  Files         281      281           
  Lines        7554     7554           
  Branches     2105     2105           
=======================================
  Hits         7322     7322           
  Misses        230      230           
  Partials        2        2
Impacted Files Coverage Δ
components/breadcrumb/Breadcrumb.tsx 96.96% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acce303...21a6d8f. Read the comment docs.

@sosohime sosohime changed the title feat:Breadcrumb support data against feat: Breadcrumb support data against Sep 22, 2019
贺业晟 added 2 commits Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants