Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Breadcrumb support data against #18941

Merged

Conversation

@sosohime
Copy link
Contributor

commented Sep 22, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#18350

💡 Background and solution

Breadcrumb 支持传入自定义 attribute

📝 Changelog

Language Changelog
🇺🇸 English Breadcrumb support data-* and aria-* attributes
🇨🇳 Chinese Breadcrumb 支持 data-* and aria-* 属性

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@pr-triage pr-triage bot added the PR: unreviewed label Sep 22, 2019
Copy link

left a comment

Could you please add tests to make sure this change works as expected?

@netlify

This comment has been minimized.

Copy link

commented Sep 22, 2019

Deploy preview for ant-design ready!

Built with commit 21a6d8f

https://deploy-preview-18941--ant-design.netlify.com

贺业晟
@codecov

This comment has been minimized.

Copy link

commented Sep 22, 2019

Codecov Report

Merging #18941 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18941   +/-   ##
=======================================
  Coverage   96.92%   96.92%           
=======================================
  Files         281      281           
  Lines        7554     7554           
  Branches     2105     2105           
=======================================
  Hits         7322     7322           
  Misses        230      230           
  Partials        2        2
Impacted Files Coverage Δ
components/breadcrumb/Breadcrumb.tsx 96.96% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acce303...21a6d8f. Read the comment docs.

贺业晟
@sosohime sosohime changed the title feat:Breadcrumb support data against feat: Breadcrumb support data against Sep 22, 2019
贺业晟 added 2 commits Sep 23, 2019
贺业晟
@shaodahong shaodahong merged commit 9f78fd0 into ant-design:master Sep 23, 2019
25 of 27 checks passed
25 of 27 checks passed
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 217 new files uploaded
Details
DEP All dependencies are resolved
LGTM analysis: JavaScript No new or fixed alerts
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing acce303...21a6d8f
Details
codecov/project 96.92% remains the same compared to acce303
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Sep 23, 2019
@shaodahong shaodahong referenced this pull request Sep 23, 2019
1 of 1 task complete
@ikobe ikobe referenced this pull request Sep 29, 2019
1 of 14 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.