Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TreeSelect removeIcon and clearIcon not working #18949

Merged
merged 9 commits into from Sep 23, 2019

Conversation

@sosohime
Copy link
Contributor

commented Sep 23, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #18870

💡 Background and solution

支持传入 removeIcon 和 clearIcon

📝 Changelog

Language Changelog
🇺🇸 English Fix TreeSelect removeIcon and clearIcon not working.
🇨🇳 Chinese

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@pr-triage pr-triage bot added the PR: unreviewed label Sep 23, 2019
@netlify

This comment has been minimized.

Copy link

commented Sep 23, 2019

Deploy preview for ant-design ready!

Built with commit 3ef8a5c

https://deploy-preview-18949--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Sep 23, 2019

Codecov Report

Merging #18949 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18949      +/-   ##
==========================================
+ Coverage   96.92%   96.93%   +<.01%     
==========================================
  Files         281      281              
  Lines        7554     7557       +3     
  Branches     2105     2110       +5     
==========================================
+ Hits         7322     7325       +3     
  Misses        230      230              
  Partials        2        2
Impacted Files Coverage Δ
components/tree-select/index.tsx 95.83% <100%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 133577f...3ef8a5c. Read the comment docs.

贺业晟 added 3 commits Sep 23, 2019
贺业晟
贺业晟
贺业晟
@afc163

This comment has been minimized.

Copy link
Member

commented Sep 23, 2019

可以加个测试用例以免后面改挂。

贺业晟
@sosohime

This comment has been minimized.

Copy link
Contributor Author

commented Sep 23, 2019

done

@afc163 afc163 changed the title feat: TreeSelect support removeIcon and clearIcon fix: TreeSelect removeIcon and clearIcon not working Sep 23, 2019
@afc163 afc163 merged commit 02ed4bd into ant-design:master Sep 23, 2019
24 of 27 checks passed
24 of 27 checks passed
DEP Checking dependencies
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 217 new files uploaded
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 96.92%)
Details
codecov/project 96.93% (+<.01%) compared to 133577f
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Sep 23, 2019
saeedrahimi added a commit to saeedrahimi/ant-design that referenced this pull request Sep 24, 2019
afc163 added a commit that referenced this pull request Sep 25, 2019
* add tree-select async demo

* TreeSelect支持clearIcon和removeIcon

* remove docs and demo

* run test

* clear code

* add ui test
@ikobe ikobe referenced this pull request Sep 29, 2019
1 of 14 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.