Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🗑 Remove useless prop `searchValue` #19003

Merged
merged 1 commit into from Sep 25, 2019

Conversation

@afc163
Copy link
Member

commented Sep 25, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #18847

💡 Background and solution

#18584 (comment)

📝 Changelog

Language Changelog
🇺🇸 English Remove Select useless prop searchValue which is a total misunderstanding.
🇨🇳 Chinese 移除实际上毫无作用的 Select searchValue 属性定义和文档。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/select/index.en-US.md
View rendered components/select/index.zh-CN.md

@pr-triage pr-triage bot added the PR: unreviewed label Sep 25, 2019
@netlify

This comment has been minimized.

Copy link

commented Sep 25, 2019

Deploy preview for ant-design ready!

Built with commit 4834227

https://deploy-preview-19003--ant-design.netlify.com

@afc163 afc163 force-pushed the remove-search-value branch from 733c48c to 9e9bc1a Sep 25, 2019
@afc163 afc163 requested a review from zombieJ Sep 25, 2019
from typescript and documentation

close #18847
@afc163 afc163 force-pushed the remove-search-value branch from 9e9bc1a to 4834227 Sep 25, 2019
@codecov

This comment has been minimized.

Copy link

commented Sep 25, 2019

Codecov Report

Merging #19003 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19003      +/-   ##
==========================================
- Coverage   96.93%   96.92%   -0.01%     
==========================================
  Files         281      281              
  Lines        7557     7555       -2     
  Branches     2068     2067       -1     
==========================================
- Hits         7325     7323       -2     
  Misses        230      230              
  Partials        2        2
Impacted Files Coverage Δ
components/select/index.tsx 96.87% <ø> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 913c5bb...4834227. Read the comment docs.

@zombieJ zombieJ merged commit 7961bb3 into master Sep 25, 2019
28 of 30 checks passed
28 of 30 checks passed
build
Details
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 217 new files uploaded
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
License Compliance All checks passed.
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
buildsize No change
Details
bundlesize Total bundle size is 582.77KB/600KB (-null)
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 913c5bb...4834227
Details
codecov/project 96.92% (-0.01%) compared to 913c5bb
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
@zombieJ zombieJ deleted the remove-search-value branch Sep 25, 2019
@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Sep 25, 2019
@ikobe ikobe referenced this pull request Sep 29, 2019
1 of 14 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.