Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🗑 Remove useless prop searchValue #19003

Merged
merged 1 commit into from Sep 25, 2019
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Sep 25, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #18847

💡 Background and solution

#18584 (comment)

📝 Changelog

Language Changelog
🇺🇸 English Remove Select useless prop searchValue which is a total misunderstanding.
🇨🇳 Chinese 移除实际上毫无作用的 Select searchValue 属性定义和文档。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/select/index.en-US.md
View rendered components/select/index.zh-CN.md

@netlify
Copy link

netlify bot commented Sep 25, 2019

Deploy preview for ant-design ready!

Built with commit 4834227

https://deploy-preview-19003--ant-design.netlify.com

from typescript and documentation

close #18847
@codecov
Copy link

codecov bot commented Sep 25, 2019

Codecov Report

Merging #19003 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19003      +/-   ##
==========================================
- Coverage   96.93%   96.92%   -0.01%     
==========================================
  Files         281      281              
  Lines        7557     7555       -2     
  Branches     2068     2067       -1     
==========================================
- Hits         7325     7323       -2     
  Misses        230      230              
  Partials        2        2
Impacted Files Coverage Δ
components/select/index.tsx 96.87% <ø> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 913c5bb...4834227. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants