Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ssr should not render string at first #19029

Merged
merged 2 commits into from Sep 27, 2019

Conversation

@zombieJ
Copy link
Member

commented Sep 27, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #19017

💡 Background and solution

From
Kapture 2019-09-27 at 12 32 35

To
Kapture 2019-09-27 at 12 33 27

📝 Changelog

Language Changelog
🇺🇸 English Fix Avatar string blink when ssr render at first time.
🇨🇳 Chinese Fix Avatar 文本头像在 ssr 时会闪烁的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@pr-triage pr-triage bot added the PR: unreviewed label Sep 27, 2019
@auto-add-label auto-add-label bot added the bug label Sep 27, 2019
@netlify

This comment has been minimized.

Copy link

commented Sep 27, 2019

Deploy preview for ant-design ready!

Built with commit 6ad4a2c

https://deploy-preview-19029--ant-design.netlify.com

@zombieJ zombieJ requested a review from afc163 Sep 27, 2019
@afc163
afc163 approved these changes Sep 27, 2019
@zombieJ zombieJ merged commit 7ae663d into master Sep 27, 2019
26 of 28 checks passed
26 of 28 checks passed
build
Details
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 219 new files uploaded
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
License Compliance All checks passed.
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
buildsize No change
Details
bundlesize Total bundle size is 582.81KB/600KB (-null)
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
@zombieJ zombieJ deleted the avatar-fix branch Sep 27, 2019
@ikobe ikobe referenced this pull request Sep 29, 2019
1 of 14 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.