Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Scrollbar on Modal Confirm #19233

Merged
merged 1 commit into from Nov 8, 2019

Conversation

@emersonlaurentino
Copy link
Contributor

emersonlaurentino commented Oct 15, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

closes #19072

馃挕 Background and solution

when opening a modal with confirm method, it makes the scrollbar active

馃摑 Changelog

removing getContainer fixed

Language Changelog
馃嚭馃嚫 English
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@pr-triage pr-triage bot added the PR: unreviewed label Oct 15, 2019
@netlify

This comment has been minimized.

Copy link

netlify bot commented Oct 15, 2019

Deploy preview for ant-design ready!

Built with commit 49cd54d

https://deploy-preview-19233--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 15, 2019

Codecov Report

Merging #19233 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #19233   +/-   ##
=======================================
  Coverage   97.78%   97.78%           
=======================================
  Files         282      282           
  Lines        7625     7625           
  Branches     2132     2144   +12     
=======================================
  Hits         7456     7456           
  Misses        169      169
Impacted Files Coverage 螖
components/modal/confirm.tsx 94.54% <100%> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update ab34970...49cd54d. Read the comment docs.

@emersonlaurentino

This comment has been minimized.

Copy link
Contributor Author

emersonlaurentino commented Oct 15, 2019

cc @afc163

Copy link
Collaborator

shaodahong left a comment

LGTM

@ztplz
ztplz approved these changes Nov 8, 2019
@yoyo837 yoyo837 changed the title Fix Scrollbar on Modal Confirm fix: Scrollbar on Modal Confirm Nov 8, 2019
@auto-add-label auto-add-label bot added the bug label Nov 8, 2019
@yoyo837 yoyo837 merged commit be0fd70 into ant-design:master Nov 8, 2019
28 checks passed
28 checks passed
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 217 new files uploaded
Details
DEP All dependencies are resolved
LGTM analysis: JavaScript No new or fixed alerts
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
buildsize No change
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 97.78%)
Details
codecov/project 97.78% (+0%) compared to ab34970
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
@pr-triage pr-triage bot added PR: merged and removed PR: reviewed-approved labels Nov 8, 2019
@emersonlaurentino emersonlaurentino deleted the emersonlaurentino:fix-modal branch Nov 8, 2019
@afc163

This comment has been minimized.

Copy link
Member

afc163 commented Nov 11, 2019

It should be reverted: #19676

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can鈥檛 perform that action at this time.