Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Table inifinite loop and defaultSortOrder #19558

Merged
merged 2 commits into from Nov 4, 2019
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Nov 4, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #19443

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Table inifinite loop when using Table.Column with sortOrder.
Fix Table defaultSortOrder not working on Table.Column.
🇨🇳 Chinese 修复 Table 在 Column 上定义 sortOrder 导致死循环的问题。
修复 Table defaultSortOrder 在 Column 上不生效的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@netlify
Copy link

netlify bot commented Nov 4, 2019

Deploy preview for ant-design ready!

Built with commit 8812ba5

https://deploy-preview-19558--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Nov 4, 2019

Codecov Report

Merging #19558 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #19558   +/-   ##
=======================================
  Coverage    97.8%    97.8%           
=======================================
  Files         284      284           
  Lines        7698     7698           
  Branches     2163     2163           
=======================================
  Hits         7529     7529           
  Misses        169      169
Impacted Files Coverage Δ
components/table/Table.tsx 99.48% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7158142...8812ba5. Read the comment docs.

@afc163 afc163 merged commit b697ef1 into master Nov 4, 2019
24 checks passed
@afc163 afc163 deleted the fix-table-loop-bug branch Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Table] Inifinite loop update when using Table.Column with sortOrder
1 participant