Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: extraCommonProps not work properly #19572

Merged
merged 2 commits into from Nov 5, 2019
Merged

Conversation

yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented Nov 5, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

fix #19551

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese 修复 extraCommonProps 不能被自己的props覆盖的问题

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Nov 5, 2019

Deploy preview for ant-design ready!

Built with commit 025be12

https://deploy-preview-19572--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Nov 5, 2019

Codecov Report

Merging #19572 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #19572   +/-   ##
=======================================
  Coverage    97.8%    97.8%           
=======================================
  Files         284      284           
  Lines        7698     7698           
  Branches     2116     2116           
=======================================
  Hits         7529     7529           
  Misses        169      169
Impacted Files Coverage Δ
components/icon/IconFont.tsx 96% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cff912...025be12. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Nov 5, 2019

来个 snapshot 用例。

@afc163 afc163 merged commit e150cfc into master Nov 5, 2019
29 checks passed
@afc163 afc163 deleted the fix-extraCommonProps-not-work branch Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants