Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Menu.ItemGroup styles inside Dropdown #19578

Merged
merged 1 commit into from Nov 5, 2019

Conversation

@afc163
Copy link
Member

afc163 commented Nov 5, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #19576
close #19145

💡 Background and solution

截屏2019-11-05下午7 15 37

to

截屏2019-11-05下午7 22 42

📝 Changelog

Language Changelog
🇺🇸 English Fix broken Menu.ItemGroup style inside Dropdown again.
🇨🇳 Chinese 再次修复 Dropdown 下 Menu.ItemGroup 样式错乱的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/dropdown/demo/menu-full.md

@pr-triage pr-triage bot added the PR: unreviewed label Nov 5, 2019
@afc163 afc163 changed the title fix Menu styles inside Dropdown fix: Menu.ItemGroup styles inside Dropdown Nov 5, 2019
@netlify

This comment has been minimized.

Copy link

netlify bot commented Nov 5, 2019

Deploy preview for ant-design ready!

Built with commit d58e7dc

https://deploy-preview-19578--ant-design.netlify.com

@auto-add-label auto-add-label bot added the bug label Nov 5, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 5, 2019

Codecov Report

Merging #19578 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #19578   +/-   ##
=======================================
  Coverage    97.8%    97.8%           
=======================================
  Files         284      284           
  Lines        7698     7698           
  Branches     2163     2151   -12     
=======================================
  Hits         7529     7529           
  Misses        169      169

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e150cfc...d58e7dc. Read the comment docs.

@afc163 afc163 merged commit 48763bf into master Nov 5, 2019
30 checks passed
30 checks passed
build
Details
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 219 new files uploaded
Details
DEP All dependencies are resolved
License Compliance All checks passed.
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
buildsize No significant change
Details
bundlesize Total bundle size is 589.73KB/600KB (-null)
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing e150cfc...d58e7dc
Details
codecov/project 97.8% remains the same compared to e150cfc
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
@afc163 afc163 deleted the fix-dropdown-style branch Nov 5, 2019
@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Nov 5, 2019
Copy link

geekrainy left a comment

dropdown 的子菜单 hover 样式超出边界

@@ -81,6 +81,7 @@
ul {
margin-right: 0.3em;
margin-left: 0.3em;
padding: 0;

This comment has been minimized.

Copy link
@geekrainy

geekrainy Nov 28, 2019

此变更导致 hover 下圆角边界被直角覆盖。 @afc163

WX20191128-095808@2x

@pr-triage pr-triage bot added PR: unreviewed and removed PR: merged labels Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.