Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Form.Item): form item passing anyother attrs #19599

Merged
merged 1 commit into from Nov 6, 2019

Conversation

@yoyo837
Copy link
Collaborator

yoyo837 commented Nov 6, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

close #19597

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese form.item 支持落地其他属性

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@auto-add-label auto-add-label bot added the chore label Nov 6, 2019
@pr-triage pr-triage bot added the PR: unreviewed label Nov 6, 2019
Copy link

tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@netlify

This comment has been minimized.

Copy link

netlify bot commented Nov 6, 2019

Deploy preview for ant-design ready!

Built with commit aeef891

https://deploy-preview-19599--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 6, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@4ded5e6). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #19599   +/-   ##
=========================================
  Coverage          ?    97.8%           
=========================================
  Files             ?      284           
  Lines             ?     7696           
  Branches          ?     2148           
=========================================
  Hits              ?     7527           
  Misses            ?      169           
  Partials          ?        0
Impacted Files Coverage Δ
components/form/FormItem.tsx 98.87% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ded5e6...aeef891. Read the comment docs.

@afc163

This comment has been minimized.

Copy link
Member

afc163 commented Nov 6, 2019

4.0 上可能也需要加。

@afc163 afc163 merged commit f38c7bb into master Nov 6, 2019
30 checks passed
30 checks passed
build
Details
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 217 new files uploaded
Details
DEP All dependencies are resolved
License Compliance All checks passed.
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
buildsize No prior size to compare - 910.88 KB
Details
bundlesize Total bundle size is 589.69KB/600KB (-null)
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch No report found to compare against
Details
codecov/project No report found to compare against
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
@afc163 afc163 deleted the form-item-passing-anyohter-attrs branch Nov 6, 2019
@yoyo837 yoyo837 mentioned this pull request Nov 7, 2019
5 of 14 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.