Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Form.Item): form item passing anyother attrs #19599

Merged
merged 1 commit into from Nov 6, 2019

Conversation

yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented Nov 6, 2019

πŸ€” This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

πŸ”— Related issue link

πŸ’‘ Background and solution

close #19597

πŸ“ Changelog

Language Changelog
πŸ‡ΊπŸ‡Έ English
πŸ‡¨πŸ‡³ Chinese form.item ζ”―ζŒθ½εœ°ε…Άδ»–ε±žζ€§

β˜‘οΈ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@netlify
Copy link

netlify bot commented Nov 6, 2019

Deploy preview for ant-design ready!

Built with commit aeef891

https://deploy-preview-19599--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Nov 6, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@4ded5e6). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #19599   +/-   ##
=========================================
  Coverage          ?    97.8%           
=========================================
  Files             ?      284           
  Lines             ?     7696           
  Branches          ?     2148           
=========================================
  Hits              ?     7527           
  Misses            ?      169           
  Partials          ?        0
Impacted Files Coverage Ξ”
components/form/FormItem.tsx 98.87% <100%> (ΓΈ)

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 4ded5e6...aeef891. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Nov 6, 2019

4.0 δΈŠε―θƒ½δΉŸιœ€θ¦εŠ γ€‚

@afc163 afc163 merged commit f38c7bb into master Nov 6, 2019
30 checks passed
@afc163 afc163 deleted the form-item-passing-anyohter-attrs branch Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants