Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: notification component support closeIcon props #19618

Merged
merged 2 commits into from Nov 8, 2019
Merged

feat: notification component support closeIcon props #19618

merged 2 commits into from Nov 8, 2019

Conversation

liuchao233
Copy link
Contributor

@liuchao233 liuchao233 commented Nov 7, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #19603

💡 Background and solution

notification component need closeIcon props just like modal component

📝 Changelog

Language Changelog
🇺🇸 English add closeIcon prop to notification component, and support global config
🇨🇳 Chinese 添加关闭图标支持 notification 组件,并支持全局配置

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/notification/index.en-US.md
View rendered components/notification/index.zh-CN.md

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@netlify
Copy link

netlify bot commented Nov 7, 2019

Deploy preview for ant-design ready!

Built with commit f5d3ed5

https://deploy-preview-19618--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Nov 7, 2019

Codecov Report

Merging #19618 into feature will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #19618      +/-   ##
===========================================
+ Coverage     97.8%    97.8%   +<.01%     
===========================================
  Files          284      284              
  Lines         7698     7703       +5     
  Branches      2163     2119      -44     
===========================================
+ Hits          7529     7534       +5     
  Misses         169      169
Impacted Files Coverage Δ
components/notification/index.tsx 96.38% <100%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42592ba...f5d3ed5. Read the comment docs.

@yoyo837 yoyo837 changed the title notification component support closeIcon props feat: notification component support closeIcon props Nov 8, 2019
afc163
afc163 approved these changes Nov 8, 2019
@afc163 afc163 merged commit 4e669d4 into ant-design:feature Nov 8, 2019
26 checks passed
@zombieJ zombieJ mentioned this pull request Dec 1, 2019
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants