Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: collect tree key should support nest children #19646

Merged
merged 3 commits into from Nov 9, 2019

Conversation

@zombieJ
Copy link
Member

zombieJ commented Nov 9, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #19644

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix DirectoryTree defaultExpandedAll not work with treeData.
🇨🇳 Chinese 修复 DirectoryTree defaultExpandedAll 在使用 treeData 时不正确的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@auto-add-label auto-add-label bot added the bug label Nov 9, 2019
@pr-triage pr-triage bot added the PR: unreviewed label Nov 9, 2019
Copy link

tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@netlify

This comment has been minimized.

Copy link

netlify bot commented Nov 9, 2019

Deploy preview for ant-design ready!

Built with commit 11d617a

https://deploy-preview-19646--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 9, 2019

Codecov Report

Merging #19646 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #19646   +/-   ##
=======================================
  Coverage    97.8%    97.8%           
=======================================
  Files         284      284           
  Lines        7704     7704           
  Branches     2122     2170   +48     
=======================================
  Hits         7535     7535           
  Misses        169      169
Impacted Files Coverage Δ
components/tree/util.ts 96.15% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cf62f6...11d617a. Read the comment docs.

@zombieJ zombieJ merged commit 451d01b into master Nov 9, 2019
28 checks passed
28 checks passed
build
Details
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 217 new files uploaded
Details
License Compliance All checks passed.
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
buildsize No change
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 97.8%)
Details
codecov/project 97.8% (+0%) compared to 0cf62f6
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
@zombieJ zombieJ deleted the fix-tree-util branch Nov 9, 2019
@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.