Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: collect tree key should support nest children #19646

Merged
merged 3 commits into from Nov 9, 2019
Merged

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Nov 9, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #19644

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix DirectoryTree defaultExpandedAll not work with treeData.
🇨🇳 Chinese 修复 DirectoryTree defaultExpandedAll 在使用 treeData 时不正确的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@netlify
Copy link

netlify bot commented Nov 9, 2019

Deploy preview for ant-design ready!

Built with commit 11d617a

https://deploy-preview-19646--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Nov 9, 2019

Codecov Report

Merging #19646 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #19646   +/-   ##
=======================================
  Coverage    97.8%    97.8%           
=======================================
  Files         284      284           
  Lines        7704     7704           
  Branches     2122     2170   +48     
=======================================
  Hits         7535     7535           
  Misses        169      169
Impacted Files Coverage Δ
components/tree/util.ts 96.15% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cf62f6...11d617a. Read the comment docs.

@zombieJ zombieJ merged commit 451d01b into master Nov 9, 2019
22 checks passed
@zombieJ zombieJ deleted the fix-tree-util branch Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Result from call to concat ignored
1 participant