Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Table #19678

Merged
merged 63 commits into from Nov 15, 2019
Merged

New Table #19678

merged 63 commits into from Nov 15, 2019

Conversation

@pr-triage pr-triage bot added the PR: draft label Nov 11, 2019
Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@zombieJ zombieJ marked this pull request as ready for review Nov 14, 2019
@pr-triage pr-triage bot removed the PR: draft label Nov 14, 2019
@zombieJ zombieJ changed the title [WIP] New Table New Table Nov 14, 2019
@afc163
Copy link
Member

@afc163 afc163 commented Nov 14, 2019

image

鍦 Firefox 涓嬫病瀵归綈銆

@afc163
Copy link
Member

@afc163 afc163 commented Nov 14, 2019

image

妯悜婊氬姩鍦 Firefox 涓嬬湅鏄庣‘姣 3.x 瑕佸崱椤裤

@afc163
Copy link
Member

@afc163 afc163 commented Nov 14, 2019

image

hover 鍒拌彍鍗曟椂锛屽浘鏍囪儗鏅珮浜笉浼氫涪澶便

@afc163
Copy link
Member

@afc163 afc163 commented Nov 14, 2019

image

Blur 杩欎釜妗嗘椂锛屾秷澶辩殑鏃跺欐诞灞備細闂姩锛3.x 娌℃湁杩欎釜闂銆

@zombieJ
Copy link
Member Author

@zombieJ zombieJ commented Nov 15, 2019

image

Blur 杩欎釜妗嗘椂锛屾秷澶辩殑鏃跺欐诞灞備細闂姩锛3.x 娌℃湁杩欎釜闂銆

@shaodahong, Please help to check on this. Seems dropdown blink with new update on Firefox. Mini reproduce:

const inputRef = React.createRef();

const menu = (
  <div style={{ padding: 16, background: '#FFF', border: '1px solid red' }}>
    <Input ref={inputRef} />
  </div>
);

ReactDOM.render(
  <Dropdown
    overlay={menu}
    trigger={['click']}
    onVisibleChange={visible => {
      if (visible) {
        setTimeout(() => inputRef.current.select());
      }
    }}
  >
    <a className="ant-dropdown-link" href="#">
      Click me <Down />
    </a>
  </Dropdown>,
  mountNode,
);

ref #19745

@zombieJ
Copy link
Member Author

@zombieJ zombieJ commented Nov 15, 2019

@afc163
Copy link
Member

@afc163 afc163 commented Nov 15, 2019

image

  • 鍙戠幇杩欎釜 Demo 鐨勭紪杈戝浘鏍囦笉瑙佷簡銆
  • 杩欎釜鏂囨澶毦鐪嬫噦浜嗭紝搴旇鏄姞杞 ****** 鏉℃暟鎹殑楂樻ц兘琛ㄦ牸銆

@zombieJ zombieJ merged commit 72a7ba6 into 4.0-prepare Nov 15, 2019
21 of 23 checks passed
@zombieJ zombieJ deleted the 4.0-table branch Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants