Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: style of search padding in transfer #19693

Merged
merged 1 commit into from Nov 13, 2019

Conversation

@Abdullah700
Copy link
Contributor

Abdullah700 commented Nov 12, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

馃挕 Background and solution

text inside the search input overlaps with the icons

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English fix text inside the search input overlaps with the icons
馃嚚馃嚦 Chinese 淇鎼滅储杈撳叆妗嗘枃鏈拰鍥炬爣閲嶅彔

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@pr-triage pr-triage bot added the PR: unreviewed label Nov 12, 2019
@netlify

This comment has been minimized.

Copy link

netlify bot commented Nov 12, 2019

Deploy preview for ant-design ready!

Built with commit f7be347

https://deploy-preview-19693--ant-design.netlify.com

@Abdullah700 Abdullah700 changed the title fix[Style] Transfer fix: style of search padding in transfer Nov 12, 2019
@auto-add-label auto-add-label bot added the bug label Nov 12, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 12, 2019

Codecov Report

Merging #19693 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #19693   +/-   ##
=======================================
  Coverage    97.8%    97.8%           
=======================================
  Files         284      284           
  Lines        7704     7704           
  Branches     2156     2170   +14     
=======================================
  Hits         7535     7535           
  Misses        169      169

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update f6af1c6...f7be347. Read the comment docs.

Copy link
Collaborator

shaodahong left a comment

LGTM

@orzyyyy

This comment has been minimized.

Copy link
Collaborator

orzyyyy commented Nov 13, 2019

Previous:
娣卞害褰曞睆_閫夋嫨鍖哄煙_20191113080046

Now:
娣卞害褰曞睆_閫夋嫨鍖哄煙_20191113080103

@orzyyyy orzyyyy merged commit 807fea0 into ant-design:master Nov 13, 2019
27 checks passed
27 checks passed
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 218 new files uploaded
Details
DEP All dependencies are resolved
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
buildsize No significant change
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing f6af1c6...f7be347
Details
codecov/project 97.8% remains the same compared to f6af1c6
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
@zombieJ

This comment has been minimized.

Copy link
Member

zombieJ commented Nov 17, 2019

Should use CSS variable instead of fixed number value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can鈥檛 perform that action at this time.