Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Table > FilterDropdownProps definition #19701

Merged
merged 1 commit into from Nov 12, 2019

Conversation

DeanVanNiekerk
Copy link
Contributor

@DeanVanNiekerk DeanVanNiekerk commented Nov 12, 2019

馃 This is a ...

  • TypeScript definition update

馃敆 Related issue link

馃挕 Background and solution

The clearFilters() function on the FilterDropdownProps interface incorrectly accepts a selectedKeys parameter when it should be accepting nothing. Solution was to remove it.

Confirmation that clearFilters accepts no arguments:

You will also noticed in the demo, clearFilters() accepts no arguments here

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English Improved some TypeScript definitions.
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Nov 12, 2019

Deploy preview for ant-design ready!

Built with commit acede61

https://deploy-preview-19701--ant-design.netlify.com

@buildsize
Copy link

buildsize bot commented Nov 12, 2019

File name Previous Size New Size Change
package-lock.json [new file] 960.79聽KB

@DeanVanNiekerk DeanVanNiekerk changed the title Fixed typing issue in Table > FilterDropdownProps fix: Table > FilterDropdownProps definition Nov 12, 2019
@auto-add-label auto-add-label bot added the bug label Nov 12, 2019
@orzyyyy orzyyyy merged commit af2dd37 into ant-design:master Nov 12, 2019
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants