Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: type interface SliderProps #19713

Merged
merged 1 commit into from Nov 13, 2019

Conversation

@jacklee814
Copy link
Contributor

jacklee814 commented Nov 13, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

Fixed #19681

馃挕 Background and solution

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@auto-add-label auto-add-label bot added the bug label Nov 13, 2019
@pr-triage pr-triage bot added the PR: unreviewed label Nov 13, 2019
@netlify

This comment has been minimized.

Copy link

netlify bot commented Nov 13, 2019

Deploy preview for ant-design ready!

Built with commit 47294f5

https://deploy-preview-19713--ant-design.netlify.com

@afc163 afc163 merged commit 3264844 into ant-design:master Nov 13, 2019
10 of 19 checks passed
10 of 19 checks passed
ci/circleci: check_metadata Your tests are queued behind your running builds
Details
ci/circleci: compile Your tests are queued behind your running builds
Details
ci/circleci: dist Your tests are queued behind your running builds
Details
ci/circleci: lint CircleCI is running your tests
Details
ci/circleci: test_dom CircleCI is running your tests
Details
ci/circleci: test_dom_15 CircleCI is running your tests
Details
ci/circleci: test_node Your tests are queued behind your running builds
Details
ci/circleci: test_node_15 CircleCI is running your tests
Details
netlify/ant-design/deploy-preview Deploy preview processing.
Details
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 218 new files uploaded
Details
DEP All dependencies are resolved
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
buildsize No change
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Nov 13, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 13, 2019

Codecov Report

Merging #19713 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #19713   +/-   ##
=======================================
  Coverage    97.8%    97.8%           
=======================================
  Files         284      284           
  Lines        7704     7704           
  Branches     2120     2154   +34     
=======================================
  Hits         7535     7535           
  Misses        169      169
Impacted Files Coverage 螖
components/slider/index.tsx 89.18% <酶> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update cedc956...47294f5. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.