Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing null option type #19722

Merged
merged 1 commit into from Nov 14, 2019

Conversation

@andelf
Copy link
Contributor

andelf commented Nov 13, 2019

See-also: https://ant.design/components/table/#components-table-demo-reset-filter

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃挕 Background and solution

Providing null for filteredValue is for cleaning the selected filter. (demo code works, this pr fixes ts type warnings.)

Type 'string[] | null' is not assignable to type 'any[] | undefined'.
Type 'null' is not assignable to type 'any[] | undefined'.ts(2322)

Providing undefined for filteredValue won't clean up the selected filter. (bug here?)

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@auto-add-label auto-add-label bot added the bug label Nov 13, 2019
@pr-triage pr-triage bot added the PR: unreviewed label Nov 13, 2019
@netlify

This comment has been minimized.

Copy link

netlify bot commented Nov 13, 2019

Deploy preview for ant-design ready!

Built with commit d385186

https://deploy-preview-19722--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 13, 2019

Codecov Report

Merging #19722 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #19722   +/-   ##
=======================================
  Coverage    97.8%    97.8%           
=======================================
  Files         284      284           
  Lines        7704     7704           
  Branches     2120     2154   +34     
=======================================
  Hits         7535     7535           
  Misses        169      169

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update dfe7fd3...d385186. Read the comment docs.

@afc163 afc163 merged commit 6860336 into ant-design:master Nov 14, 2019
27 checks passed
27 checks passed
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 217 new files uploaded
Details
DEP All dependencies are resolved
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
buildsize No change
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing dfe7fd3...d385186
Details
codecov/project 97.8% remains the same compared to dfe7fd3
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Nov 14, 2019
@andelf andelf deleted the andelf:patch-1 branch Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.