Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TimePicker): fix time-picker disabled item focus style #19812

Merged
merged 1 commit into from Nov 22, 2019

Conversation

@yoyo837
Copy link
Collaborator

yoyo837 commented Nov 20, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

ref: #17447

馃挕 Background and solution

fix #19785

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English fix Time-picker disabled item focus style
馃嚚馃嚦 Chinese time-picker 绂佺敤椤硅仛鐒︽椂鏍峰紡淇

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@pr-triage pr-triage bot added the PR: unreviewed label Nov 20, 2019
@netlify

This comment has been minimized.

Copy link

netlify bot commented Nov 20, 2019

Deploy preview for ant-design ready!

Built with commit 0505b15

https://deploy-preview-19812--ant-design.netlify.com

@yoyo837

This comment has been minimized.

Copy link
Collaborator Author

yoyo837 commented Nov 20, 2019

workflows crash...

@codesandbox

This comment has been minimized.

Copy link

codesandbox bot commented Nov 20, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0505b15:

Sandbox Source
antd reproduction template Configuration
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 20, 2019

Codecov Report

Merging #19812 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #19812   +/-   ##
=======================================
  Coverage    97.8%    97.8%           
=======================================
  Files         284      284           
  Lines        7705     7705           
  Branches     2120     2120           
=======================================
  Hits         7536     7536           
  Misses        169      169

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update c57d7f3...0505b15. Read the comment docs.

@yoyo837 yoyo837 changed the title fix time-picker disabled item focus style fix(TimePicker): fix time-picker disabled item focus style Nov 20, 2019
@auto-add-label auto-add-label bot added the bug label Nov 20, 2019
@yoyo837 yoyo837 requested a review from afc163 Nov 20, 2019
@yoyo837 yoyo837 force-pushed the fix-time-picker-disabled-focus branch from 08fe73b to 0505b15 Nov 21, 2019
@afc163 afc163 merged commit 040fe56 into master Nov 22, 2019
36 checks passed
36 checks passed
setup
Details
compile
Details
dist
Details
lint
Details
node
Details
lib
Details
es
Details
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 217 new files uploaded
Details
License Compliance All checks passed.
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
buildsize No change
Details
bundlesize Total bundle size is 589.03KB/600KB (-null)
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
ci/codesandbox Building packages succeeded.
Details
codecov/patch Coverage not affected when comparing c57d7f3...0505b15
Details
codecov/project 97.8% remains the same compared to c57d7f3
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
@afc163 afc163 deleted the fix-time-picker-disabled-focus branch Nov 22, 2019
@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Nov 22, 2019
@ycjcl868 ycjcl868 mentioned this pull request Nov 25, 2019
1 of 14 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.