Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 4.0 danger button #19837

Merged
merged 16 commits into from Nov 29, 2019
Merged

feat: 4.0 danger button #19837

merged 16 commits into from Nov 29, 2019

Conversation

ycjcl868
Copy link
Member

@ycjcl868 ycjcl868 commented Nov 20, 2019

  • search icon Button show tooltip search
  • remove Button group demo
  • remove Button dashed ghost demo
  • tweak form-demo-advanced-demo collapse and icon position
  • remove Button icon loading demo
  • add Button danger, deprecated type="danger"
  • remove Table actions demo Divider, using margin 16px instead.

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

馃挕 Background and solution

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/button/demo/button-group.md
View rendered components/button/demo/ghost.md
View rendered components/button/demo/icon.md
View rendered components/form/demo/form-context.md

@auto-add-label auto-add-label bot added the bug label Nov 20, 2019
@netlify
Copy link

@netlify netlify bot commented Nov 20, 2019

Deploy preview for ant-design ready!

Built with commit e8dd412

https://deploy-preview-19837--ant-design.netlify.com

@codecov
Copy link

@codecov codecov bot commented Nov 20, 2019

Codecov Report

Merging #19837 into 4.0-prepare will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           4.0-prepare   #19837   +/-   ##
============================================
  Coverage        97.55%   97.55%           
============================================
  Files              292      292           
  Lines             7210     7210           
  Branches          1994     1956   -38     
============================================
  Hits              7034     7034           
  Misses             176      176
Impacted Files Coverage 螖
components/button/button.tsx 100% <酶> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 5ef6b04...e8dd412. Read the comment docs.

@ycjcl868
Copy link
Member Author

@ycjcl868 ycjcl868 commented Nov 25, 2019

/rebase

@buildsize
Copy link

@buildsize buildsize bot commented Nov 25, 2019

File name Previous Size New Size Change
package-lock.json 977.33聽KB 978.06聽KB 750聽bytes (0%)

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Nov 29, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6ca5628:

Sandbox Source
antd reproduction template Configuration

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Nov 29, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e8dd412:

Sandbox Source
antd reproduction template Configuration

@ycjcl868 ycjcl868 changed the title [WIP] fix: button demo feat: 4.0 danger button Nov 29, 2019
@@ -96,7 +96,7 @@ const Demo = () => {
<ul>
{users.map((user, index) => (
<li key={index} className="user">
<Avatar icon="user" />
<Avatar icon={<User />} />
Copy link
Member Author

@ycjcl868 ycjcl868 Nov 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

鏈夌偣闂

@ycjcl868 ycjcl868 merged commit 4357444 into 4.0-prepare Nov 29, 2019
30 checks passed
@ycjcl868 ycjcl868 deleted the fix-button-demo branch Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants