Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ๐Ÿ’„ Add @table-header-bg-sm and fix footer style #19939

Merged
merged 1 commit into from Nov 27, 2019

Conversation

@afc163
Copy link
Member

afc163 commented Nov 26, 2019

๐Ÿค” This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

๐Ÿ”— Related issue link

close #19936

๐Ÿ’ก Background and solution

  1. Add less variable @table-header-bg-sm.

  2. Fixed
    image

    to

    image

๐Ÿ“ Changelog

Language Changelog
๐Ÿ‡บ๐Ÿ‡ธ English - Add less variable @table-header-bg-sm.
- Fix small Table footer style.
๐Ÿ‡จ๐Ÿ‡ณ Chinese - ๆ–ฐๅขž less ๅ˜้‡ @table-header-bg-smใ€‚
- ไฟฎๅคๅฐๅท Table ็š„ footer ๆ ทๅผใ€‚

โ˜‘๏ธ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@pr-triage pr-triage bot added the PR: unreviewed label Nov 26, 2019
@auto-add-label auto-add-label bot added the lipstick label Nov 26, 2019
@afc163 afc163 changed the title :lipstick: Add @table-header-bg-sm and fix footer style feat: ๐Ÿ’„ Add @table-header-bg-sm and fix footer style Nov 26, 2019
@auto-add-label auto-add-label bot added enhancement and removed lipstick labels Nov 26, 2019
@netlify

This comment has been minimized.

Copy link

netlify bot commented Nov 26, 2019

Deploy preview for ant-design ready!

Built with commit 3fa1350

https://deploy-preview-19939--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 26, 2019

Codecov Report

Merging #19939 into feature will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #19939   +/-   ##
========================================
  Coverage    97.81%   97.81%           
========================================
  Files          286      286           
  Lines         7722     7722           
  Branches      2126     2160   +34     
========================================
  Hits          7553     7553           
  Misses         169      169

Continue to review full report at Codecov.

Legend - Click here to learn more
ฮ” = absolute <relative> (impact), รธ = not affected, ? = missing data
Powered by Codecov. Last update 103920e...3fa1350. Read the comment docs.

@zombieJ zombieJ assigned ycjcl868 and unassigned zombieJ Nov 27, 2019
@zombieJ

This comment has been minimized.

Copy link
Member

zombieJ commented Nov 27, 2019

@ycjcl868 Should help to merge into 4.0 branch also.

@ycjcl868

This comment has been minimized.

Copy link
Member

ycjcl868 commented Nov 27, 2019

Looks like compact mode in 4.0, whether to adjust through a configuration in ConfigProvider

@ycjcl868 ycjcl868 merged commit 69e3b87 into feature Nov 27, 2019
30 checks passed
30 checks passed
build
Details
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 217 new files uploaded
Details
DEP All dependencies are resolved
License Compliance All checks passed.
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
buildsize No prior size to compare - 963.19ย KB
Details
bundlesize Total bundle size is 591.75KB/600KB (-null)
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 103920e...3fa1350
Details
codecov/project 97.81% remains the same compared to 103920e
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
@ycjcl868 ycjcl868 deleted the @table-small-header-bg branch Nov 27, 2019
@zombieJ zombieJ mentioned this pull request Dec 1, 2019
1 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You canโ€™t perform that action at this time.