Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Spin): should not be render default indicator when indicator value is null #19943

Merged
merged 1 commit into from Nov 27, 2019

Conversation

@shaodahong
Copy link
Collaborator

shaodahong commented Nov 26, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

Fixes #19940

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Spin render default indicator when it is null
🇨🇳 Chinese 修复 Spin 在 indicator 属性为 null 时,渲染默认的 indicator

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@auto-add-label auto-add-label bot added the bug label Nov 26, 2019
@pr-triage pr-triage bot added the PR: unreviewed label Nov 26, 2019
Copy link

tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@netlify

This comment has been minimized.

Copy link

netlify bot commented Nov 26, 2019

Deploy preview for ant-design ready!

Built with commit 5848b0c

https://deploy-preview-19943--ant-design.netlify.com

@codesandbox

This comment has been minimized.

Copy link

codesandbox bot commented Nov 26, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5848b0c:

Sandbox Source
antd reproduction template Configuration
sharp-tdd-jnj62 Issue #19940
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 26, 2019

Codecov Report

Merging #19943 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19943      +/-   ##
==========================================
+ Coverage    97.8%    97.8%   +<.01%     
==========================================
  Files         284      284              
  Lines        7705     7707       +2     
  Branches     2168     2166       -2     
==========================================
+ Hits         7536     7538       +2     
  Misses        169      169
Impacted Files Coverage Δ
components/spin/index.tsx 95.31% <100%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c781082...5848b0c. Read the comment docs.

@orzyyyy orzyyyy merged commit bed1f77 into ant-design:master Nov 27, 2019
28 checks passed
28 checks passed
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 217 new files uploaded
Details
DEP All dependencies are resolved
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
buildsize No change
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
ci/codesandbox Building packages succeeded.
Details
codecov/patch 100% of diff hit (target 97.8%)
Details
codecov/project 97.8% (+<.01%) compared to c781082
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
@shaodahong shaodahong deleted the shaodahong:fix-spin-indicator-null branch Nov 27, 2019
@zombieJ zombieJ mentioned this pull request Dec 1, 2019
1 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.