Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Button): Button disabled with loading not prevent pointer-events #19958

Merged

Conversation

@shaodahong
Copy link
Collaborator

shaodahong commented Nov 27, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

Fixes #19954

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Button component disabled with loading not prevent pointer-events
🇨🇳 Chinese 修复 Button 组件 disabledloading 状态下没有阻止鼠标事件

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@pr-triage pr-triage bot added the PR: unreviewed label Nov 27, 2019
@auto-add-label auto-add-label bot added the bug label Nov 27, 2019
@netlify

This comment has been minimized.

Copy link

netlify bot commented Nov 27, 2019

Deploy preview for ant-design ready!

Built with commit 4dc519c

https://deploy-preview-19958--ant-design.netlify.com

@afc163 afc163 merged commit 6030431 into ant-design:master Nov 27, 2019
8 of 11 checks passed
8 of 11 checks passed
ci/circleci: setup CircleCI is running your tests
Details
ci/codesandbox Building packages...
Details
netlify/ant-design/deploy-preview Deploy preview processing.
Details
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 218 new files uploaded
Details
DEP All dependencies are resolved
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
security/snyk - package.json (paranoidjk) No new issues
Details
@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Nov 27, 2019
@codesandbox

This comment has been minimized.

Copy link

codesandbox bot commented Nov 27, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4dc519c:

Sandbox Source
antd reproduction template Configuration
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 27, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@bed1f77). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #19958   +/-   ##
=========================================
  Coverage          ?    97.8%           
=========================================
  Files             ?      284           
  Lines             ?     7705           
  Branches          ?     2120           
=========================================
  Hits              ?     7536           
  Misses            ?      169           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bed1f77...4dc519c. Read the comment docs.

@zombieJ zombieJ mentioned this pull request Dec 1, 2019
1 of 10 tasks complete
@shaodahong shaodahong deleted the shaodahong:fix-button-disabled-with-loading branch Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.