Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update message content with a unique key and cancel manually #19967

Merged
merged 1 commit into from Nov 28, 2019

Conversation

@Aemple
Copy link
Contributor

Aemple commented Nov 27, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

#18678

馃挕 Background and solution

close #19950

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English repair update message content with a unique key can鈥榯 cancel manually
馃嚚馃嚦 Chinese 淇message缁勪欢浣跨敤key鏃舵棤娉曟墜鍔ㄥ彇娑堢殑鎯呭喌

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/message/demo/update.md

@auto-add-label auto-add-label bot added the bug label Nov 27, 2019
@pr-triage pr-triage bot added the PR: unreviewed label Nov 27, 2019
Copy link

tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@netlify

This comment has been minimized.

Copy link

netlify bot commented Nov 27, 2019

Deploy preview for ant-design ready!

Built with commit 22c13f5

https://deploy-preview-19967--ant-design.netlify.com

@codesandbox

This comment has been minimized.

Copy link

codesandbox bot commented Nov 27, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 22c13f5:

Sandbox Source
antd reproduction template Configuration
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 27, 2019

Codecov Report

Merging #19967 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19967      +/-   ##
==========================================
- Coverage    97.8%    97.8%   -0.01%     
==========================================
  Files         284      284              
  Lines        7707     7706       -1     
  Branches     2169     2155      -14     
==========================================
- Hits         7538     7537       -1     
  Misses        169      169
Impacted Files Coverage 螖
components/message/index.tsx 94.2% <100%> (-0.09%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 2d82b59...22c13f5. Read the comment docs.

@yoyo837 yoyo837 merged commit d6430ad into ant-design:master Nov 28, 2019
27 checks passed
27 checks passed
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 218 new files uploaded
Details
DEP All dependencies are resolved
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
ci/codesandbox Building packages succeeded.
Details
codecov/patch 100% of diff hit (target 97.8%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +2.19% compared to 2d82b59
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
@zombieJ zombieJ mentioned this pull request Dec 1, 2019
1 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.