Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Upload.Dragger): move className and Style pass to ant-upload-drag #19987

Merged
merged 1 commit into from Nov 28, 2019

Conversation

@yoyo837
Copy link
Collaborator

yoyo837 commented Nov 28, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#19985

💡 Background and solution

close #19945

📝 Changelog

Language Changelog
🇺🇸 English move className and Style pass ant-upload-drag
🇨🇳 Chinese className和style样式统一赋予drag 的 div

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@pr-triage pr-triage bot added the PR: unreviewed label Nov 28, 2019
@auto-add-label auto-add-label bot added the bug label Nov 28, 2019
@netlify

This comment has been minimized.

Copy link

netlify bot commented Nov 28, 2019

Deploy preview for ant-design ready!

Built with commit 65950e9

https://deploy-preview-19987--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 28, 2019

Codecov Report

Merging #19987 into feature will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #19987      +/-   ##
===========================================
+ Coverage    97.81%   97.81%   +<.01%     
===========================================
  Files          286      286              
  Lines         7722     7723       +1     
  Branches      2174     2126      -48     
===========================================
+ Hits          7553     7554       +1     
  Misses         169      169
Impacted Files Coverage Δ
components/upload/Upload.tsx 99.23% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 965bc58...65950e9. Read the comment docs.

@yoyo837 yoyo837 changed the title fix(Upload.Dragger): move className and style to ant-upload-drag fix(Upload.Dragger): move className and Style pass to ant-upload-drag Nov 28, 2019
@afc163
afc163 approved these changes Nov 28, 2019
@afc163 afc163 merged commit c824569 into feature Nov 28, 2019
28 of 29 checks passed
28 of 29 checks passed
build
Details
License Compliance FOSSA is analyzing this commit
Details
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 217 new files uploaded
Details
DEP All dependencies are resolved
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
bundlesize Total bundle size is 591.77KB/600KB (-null)
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 97.81%)
Details
codecov/project 97.81% (+<.01%) compared to 965bc58
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
@afc163 afc163 deleted the style-pass-wrapper branch Nov 28, 2019
@zombieJ zombieJ mentioned this pull request Dec 1, 2019
1 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.