Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ๐Ÿ› Slider tooltip not aligned center #20016

Merged
merged 1 commit into from Nov 30, 2019

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Nov 30, 2019

๐Ÿค” This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

๐Ÿ”— Related issue link

close #20014

๐Ÿ’ก Background and solution

๐Ÿ“ Changelog

Language Changelog
๐Ÿ‡บ๐Ÿ‡ธ English Fix Slider tooltip text not align center.
๐Ÿ‡จ๐Ÿ‡ณ Chinese ไฟฎๅค Slider ็š„ tooltip ๅ†…ๅฎนๆฒกๆœ‰ๅฑ…ไธญ็š„้—ฎ้ข˜ใ€‚

โ˜‘๏ธ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@auto-add-label auto-add-label bot added the bug label Nov 30, 2019
@afc163 afc163 changed the title ๐Ÿ› Fix Slider tooltip not aligned center fix: ๐Ÿ› Slider tooltip not aligned center Nov 30, 2019
@netlify
Copy link

netlify bot commented Nov 30, 2019

Deploy preview for ant-design ready!

Built with commit e5c1220

https://deploy-preview-20016--ant-design.netlify.com

@afc163 afc163 force-pushed the fix-slider-tooltip-align branch from 3bee393 to 5201a58 Compare Nov 30, 2019
@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 30, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3bee3937269ec75e1b8ab7d404cb3e21c9c775ff:

Sandbox Source
antd reproduction template Configuration

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 30, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e5c1220:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Nov 30, 2019

Codecov Report

Merging #20016 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #20016   +/-   ##
=======================================
  Coverage    97.8%    97.8%           
=======================================
  Files         284      284           
  Lines        7706     7706           
  Branches     2155     2121   -34     
=======================================
  Hits         7537     7537           
  Misses        169      169
Impacted Files Coverage ฮ”
components/slider/index.tsx 89.18% <100%> (รธ) โฌ†๏ธ

Continue to review full report at Codecov.

Legend - Click here to learn more
ฮ” = absolute <relative> (impact), รธ = not affected, ? = missing data
Powered by Codecov. Last update 74e0587...e5c1220. Read the comment docs.

@afc163 afc163 force-pushed the fix-slider-tooltip-align branch from 5201a58 to e5c1220 Compare Nov 30, 2019
@afc163 afc163 merged commit 0ec7fa8 into master Nov 30, 2019
35 checks passed
@afc163 afc163 deleted the fix-slider-tooltip-align branch Nov 30, 2019
@zombieJ zombieJ mentioned this pull request Dec 1, 2019
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant