Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ๐Ÿ› Input clear icon overclap with feedback icon #20017

Merged
merged 1 commit into from Nov 30, 2019

Conversation

@afc163
Copy link
Member

afc163 commented Nov 30, 2019

๐Ÿค” This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

๐Ÿ”— Related issue link

close #19884

๐Ÿ’ก Background and solution

๐Ÿ“ Changelog

Language Changelog
๐Ÿ‡บ๐Ÿ‡ธ English Fix Input clear icon overclap with feedback icon.
๐Ÿ‡จ๐Ÿ‡ณ Chinese ไฟฎๅค Input ๆธ…้™คๅ›พๆ ‡ๅ’Œๅ้ฆˆๅ›พๆ ‡้‡ๅˆ็š„้—ฎ้ข˜ใ€‚

โ˜‘๏ธ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
close #19884
@pr-triage pr-triage bot added the PR: unreviewed label Nov 30, 2019
@auto-add-label auto-add-label bot added the bug label Nov 30, 2019
@netlify

This comment has been minimized.

Copy link

netlify bot commented Nov 30, 2019

Deploy preview for ant-design ready!

Built with commit 803e443

https://deploy-preview-20017--ant-design.netlify.com

@codesandbox

This comment has been minimized.

Copy link

codesandbox bot commented Nov 30, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 803e443:

Sandbox Source
antd reproduction template Configuration
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 30, 2019

Codecov Report

Merging #20017 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #20017   +/-   ##
=======================================
  Coverage    97.8%    97.8%           
=======================================
  Files         284      284           
  Lines        7706     7706           
  Branches     2155     2169   +14     
=======================================
  Hits         7537     7537           
  Misses        169      169

Continue to review full report at Codecov.

Legend - Click here to learn more
ฮ” = absolute <relative> (impact), รธ = not affected, ? = missing data
Powered by Codecov. Last update 74e0587...803e443. Read the comment docs.

@afc163 afc163 changed the title fix: ๐Ÿ› Input clear icon overclap with feedback ico fix: ๐Ÿ› Input clear icon overclap with feedback icon Nov 30, 2019
@afc163 afc163 merged commit 329edc1 into master Nov 30, 2019
36 checks passed
36 checks passed
setup
Details
compile
Details
dist
Details
lint
Details
node
Details
lib
Details
es
Details
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 217 new files uploaded
Details
DEP All dependencies are resolved
License Compliance All checks passed.
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
bundlesize Total bundle size is 591.88KB/600KB (-null)
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
ci/codesandbox Building packages succeeded.
Details
codecov/patch Coverage not affected when comparing 74e0587...803e443
Details
codecov/project 97.8% remains the same compared to 74e0587
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
@afc163 afc163 deleted the fix-feedback-input branch Nov 30, 2019
@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Nov 30, 2019
@zombieJ zombieJ mentioned this pull request Dec 1, 2019
1 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You canโ€™t perform that action at this time.