Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ๐Ÿ› Descriptions items not working with React.Fragment #20019

Merged
merged 1 commit into from Nov 30, 2019

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Nov 30, 2019

๐Ÿค” This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

๐Ÿ”— Related issue link

close #19887

๐Ÿ’ก Background and solution

๐Ÿ“ Changelog

Language Changelog
๐Ÿ‡บ๐Ÿ‡ธ English Fix Descriptions items not working with React.Fragment
๐Ÿ‡จ๐Ÿ‡ณ Chinese ไฟฎๅค Descriptions ๅ†…ไฝฟ็”จ React.Fragment ็š„ๆธฒๆŸ“้—ฎ้ข˜ใ€‚

โ˜‘๏ธ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@netlify
Copy link

netlify bot commented Nov 30, 2019

Deploy preview for ant-design ready!

Built with commit 4b73aa1

https://deploy-preview-20019--ant-design.netlify.com

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 30, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4b73aa1:

Sandbox Source
antd reproduction template Configuration
antd reproduction template Issue #19887

@codecov
Copy link

codecov bot commented Nov 30, 2019

Codecov Report

Merging #20019 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #20019      +/-   ##
==========================================
+ Coverage    97.8%    97.8%   +<.01%     
==========================================
  Files         284      284              
  Lines        7706     7714       +8     
  Branches     2155     2168      +13     
==========================================
+ Hits         7537     7545       +8     
  Misses        169      169
Impacted Files Coverage ฮ”
components/descriptions/index.tsx 98.92% <100%> (+0.1%) โฌ†๏ธ

Continue to review full report at Codecov.

Legend - Click here to learn more
ฮ” = absolute <relative> (impact), รธ = not affected, ? = missing data
Powered by Codecov. Last update 74e0587...4b73aa1. Read the comment docs.

@afc163 afc163 merged commit d7e8102 into master Nov 30, 2019
36 checks passed
@afc163 afc163 deleted the fix-descriptions-fragment branch Nov 30, 2019
@zombieJ zombieJ mentioned this pull request Dec 1, 2019
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant