Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New Picker #20023

Merged
merged 97 commits into from Dec 11, 2019
Merged

feat: New Picker #20023

merged 97 commits into from Dec 11, 2019

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Dec 1, 2019

Preview

https://deploy-preview-20023--ant-design.netlify.com/components/date-picker-cn/#header

馃敆 Related issue link

close #19747

馃挕 Background and solution

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/calendar/demo/basic.md
View rendered components/calendar/demo/card.md
View rendered components/date-picker/demo/basic.md
View rendered components/date-picker/demo/extra-footer.md
View rendered components/date-picker/demo/format.md
View rendered components/date-picker/demo/mode.md

@netlify
Copy link

@netlify netlify bot commented Dec 1, 2019

Deploy preview for ant-design ready!

Built with commit 05f4704

https://deploy-preview-20023--ant-design.netlify.com

@zombieJ
Copy link
Member Author

@zombieJ zombieJ commented Dec 11, 2019

  • Week picker missing today border when selected

鎴睆2019-12-11涓嬪崍3 03 13

@zombieJ
Copy link
Member Author

@zombieJ zombieJ commented Dec 11, 2019

Updated. Check again.

@afc163
Copy link
Member

@afc163 afc163 commented Dec 11, 2019

DatePicker 鍜 TimePicker 鐨勫唴 padding 瑕佸 4px銆

image

@afc163
Copy link
Member

@afc163 afc163 commented Dec 11, 2019

image

@zombieJ
Copy link
Member Author

@zombieJ zombieJ commented Dec 11, 2019

Updated

@afc163
Copy link
Member

@afc163 afc163 commented Dec 11, 2019

image

https://github.com/ant-design/ant-design/pull/20023/checks?check_run_id=343585583

杩欎釜 snapshot 鐪嬬潃濂藉鎬

@zombieJ
Copy link
Member Author

@zombieJ zombieJ commented Dec 11, 2019

All green~

@zombieJ zombieJ merged commit 407a41a into 4.0-prepare Dec 11, 2019
30 checks passed
Ant Design 4.0 Release Candidate automation moved this from In progress to Done Dec 11, 2019
@zombieJ zombieJ deleted the 4.0-picker branch Dec 11, 2019
@pr-triage pr-triage bot added the PR: merged label Dec 11, 2019
@zombieJ
Copy link
Member Author

@zombieJ zombieJ commented Dec 11, 2019

@saeedrahimi , Picker merged. Since currently have some issue about other rewrite component, beta verison will rolling update by fixing. We can merge RTL between rolling update.

@saeedrahimi
Copy link
Contributor

@saeedrahimi saeedrahimi commented Dec 12, 2019

@saeedrahimi , Picker merged. Since currently have some issue about other rewrite component, beta verison will rolling update by fixing. We can merge RTL between rolling update.

I'm working on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

7 participants