Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: New Picker #20023

Merged
merged 97 commits into from Dec 11, 2019
Merged

feat: New Picker #20023

merged 97 commits into from Dec 11, 2019

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Dec 1, 2019 •
edited

Preview

https://deploy-preview-20023--ant-design.netlify.com/components/date-picker-cn/#header

🔗 Related issue link

close #19747

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/calendar/demo/basic.md
View rendered components/calendar/demo/card.md
View rendered components/date-picker/demo/basic.md
View rendered components/date-picker/demo/extra-footer.md
View rendered components/date-picker/demo/format.md
View rendered components/date-picker/demo/mode.md

zombieJ added 24 commits Nov 28, 2019
@pr-triage pr-triage bot added the PR: draft label Dec 1, 2019
@netlify
Copy link

@netlify netlify bot commented Dec 1, 2019 •
edited

Deploy preview for ant-design ready!

Built with commit 05f4704

https://deploy-preview-20023--ant-design.netlify.com

@zombieJ
Copy link
Member Author

@zombieJ zombieJ commented Dec 11, 2019 •
edited

  • Week picker missing today border when selected

截屏2019-12-11下午3 03 13

@zombieJ
Copy link
Member Author

@zombieJ zombieJ commented Dec 11, 2019

Updated. Check again.

@afc163
Copy link
Member

@afc163 afc163 commented Dec 11, 2019

DatePicker 和 TimePicker 的内 padding 要多 4px。

image

@afc163
Copy link
Member

@afc163 afc163 commented Dec 11, 2019

image

@zombieJ
Copy link
Member Author

@zombieJ zombieJ commented Dec 11, 2019

Updated

@afc163
Copy link
Member

@afc163 afc163 commented Dec 11, 2019 •
edited

image

https://github.com/ant-design/ant-design/pull/20023/checks?check_run_id=343585583

这个 snapshot 看着好奇怪。

@zombieJ
Copy link
Member Author

@zombieJ zombieJ commented Dec 11, 2019

All green~

@zombieJ zombieJ merged commit 407a41a into 4.0-prepare Dec 11, 2019
30 checks passed
Ant Design 4.0 Release Candidate automation moved this from In progress to Done Dec 11, 2019
@zombieJ zombieJ deleted the 4.0-picker branch Dec 11, 2019
@pr-triage pr-triage bot added the PR: merged label Dec 11, 2019
@zombieJ
Copy link
Member Author

@zombieJ zombieJ commented Dec 11, 2019 •
edited

@saeedrahimi , Picker merged. Since currently have some issue about other rewrite component, beta verison will rolling update by fixing. We can merge RTL between rolling update.

@yoyo837 yoyo837 mentioned this pull request Dec 12, 2019
Merged
76 tasks
@saeedrahimi
Copy link
Contributor

@saeedrahimi saeedrahimi commented Dec 12, 2019

@saeedrahimi , Picker merged. Since currently have some issue about other rewrite component, beta verison will rolling update by fixing. We can merge RTL between rolling update.

I'm working on it

@weekly-digest weekly-digest bot mentioned this pull request Dec 15, 2019
Closed
@hsuanxyz hsuanxyz mentioned this pull request Dec 31, 2019
Closed
@zombieJ zombieJ mentioned this pull request Feb 4, 2020
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afc163 afc163

@chenshuai2144 chenshuai2144

Assignees
No one assigned
Labels
4.x
Projects
No open projects
Ant Design 4.0 Release Candidate
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@zombieJ @afc163 @crazyair @yoyo837 @ztplz @saeedrahimi @chenshuai2144