Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New Picker #20023

Merged
merged 97 commits into from
Dec 11, 2019
Merged

feat: New Picker #20023

merged 97 commits into from
Dec 11, 2019

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Dec 1, 2019

Preview

https://deploy-preview-20023--ant-design.netlify.com/components/date-picker-cn/#header

🔗 Related issue link

close #19747

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/calendar/demo/basic.md
View rendered components/calendar/demo/card.md
View rendered components/date-picker/demo/basic.md
View rendered components/date-picker/demo/extra-footer.md
View rendered components/date-picker/demo/format.md
View rendered components/date-picker/demo/mode.md

@netlify
Copy link

netlify bot commented Dec 1, 2019

Deploy preview for ant-design ready!

Built with commit 05f4704

https://deploy-preview-20023--ant-design.netlify.com

@zombieJ
Copy link
Member Author

zombieJ commented Dec 11, 2019

  • Week picker missing today border when selected

截屏2019-12-11下午3 03 13

@zombieJ
Copy link
Member Author

zombieJ commented Dec 11, 2019

Updated. Check again.

@afc163
Copy link
Member

afc163 commented Dec 11, 2019

DatePicker 和 TimePicker 的内 padding 要多 4px。

image

@afc163
Copy link
Member

afc163 commented Dec 11, 2019

image

@zombieJ
Copy link
Member Author

zombieJ commented Dec 11, 2019

Updated

@afc163
Copy link
Member

afc163 commented Dec 11, 2019

@zombieJ
Copy link
Member Author

zombieJ commented Dec 11, 2019

All green~

@zombieJ zombieJ merged commit 407a41a into 4.0-prepare Dec 11, 2019
@zombieJ zombieJ deleted the 4.0-picker branch December 11, 2019 15:32
@pr-triage pr-triage bot added the PR: merged label Dec 11, 2019
@zombieJ
Copy link
Member Author

zombieJ commented Dec 11, 2019

@saeedrahimi , Picker merged. Since currently have some issue about other rewrite component, beta verison will rolling update by fixing. We can merge RTL between rolling update.

@saeedrahimi
Copy link
Contributor

@saeedrahimi , Picker merged. Since currently have some issue about other rewrite component, beta verison will rolling update by fixing. We can merge RTL between rolling update.

I'm working on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x In Ant Design 4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants