Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DescriptionItem className error to label #20067

Merged
merged 1 commit into from Dec 3, 2019
Merged

fix: DescriptionItem className error to label #20067

merged 1 commit into from Dec 3, 2019

Conversation

Liu-Ya
Copy link
Contributor

@Liu-Ya Liu-Ya commented Dec 3, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #20063

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix DescriptionItem className error applied to label.
🇨🇳 Chinese 修复DescriptionItem的className错误应用于label。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Dec 3, 2019

Deploy preview for ant-design ready!

Built with commit 049f328

https://deploy-preview-20067--ant-design.netlify.com

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 3, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 049f328:

Sandbox Source
antd reproduction template Configuration
antd reproduction template Issue #20063

@codecov
Copy link

codecov bot commented Dec 3, 2019

Codecov Report

Merging #20067 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #20067   +/-   ##
=======================================
  Coverage   97.81%   97.81%           
=======================================
  Files         286      286           
  Lines        7737     7737           
  Branches     2176     2128   -48     
=======================================
  Hits         7568     7568           
  Misses        169      169
Impacted Files Coverage Δ
components/descriptions/Col.tsx 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43bf796...049f328. Read the comment docs.

@afc163 afc163 requested a review from chenshuai2144 Dec 3, 2019
@yoyo837 yoyo837 merged commit 3fed6f0 into ant-design:master Dec 3, 2019
27 checks passed
@SourceCipher
Copy link

SourceCipher commented Jan 8, 2020

Why on earth the class name was removed? Whats the point having the class name applied only for the content and not the label as well since they are both a part of 1 component?

@SourceCipher
Copy link

SourceCipher commented Feb 20, 2020

@chenshuai2144 Revert this plz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants