Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Icon component ts error with cra definition #20142

Merged
merged 2 commits into from Dec 9, 2019
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Dec 9, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #13205
close #19638

💡 Background and solution

https://github.com/facebook/create-react-app/blob/f09d3d3a52c1b938cecc977c2bbc0942ea0a7e70/packages/react-scripts/lib/react-app.d.ts#L42-L49

📝 Changelog

Language Changelog
🇺🇸 English Improve Icon component definition to be compatible with create-react-app svg component.
🇨🇳 Chinese 修复 Icon component 的定义,使其兼容于 create-react-app 的 svg 组件定义。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@netlify
Copy link

netlify bot commented Dec 9, 2019

Deploy preview for ant-design ready!

Built with commit 63ba951

https://deploy-preview-20142--ant-design.netlify.com

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 9, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 63ba951:

Sandbox Source
antd reproduction template Configuration

@afc163 afc163 force-pushed the fix-icon-component-ts branch from d181b68 to d4127e1 Compare Dec 9, 2019
@codecov
Copy link

codecov bot commented Dec 9, 2019

Codecov Report

Merging #20142 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #20142   +/-   ##
=======================================
  Coverage   97.81%   97.81%           
=======================================
  Files         286      286           
  Lines        7739     7739           
  Branches     2177     2166   -11     
=======================================
  Hits         7570     7570           
  Misses        169      169
Impacted Files Coverage Δ
components/icon/index.tsx 88% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea1f00d...63ba951. Read the comment docs.

@afc163 afc163 force-pushed the fix-icon-component-ts branch from d4127e1 to 89c917d Compare Dec 9, 2019
@@ -184,7 +184,7 @@
"eslint-config-airbnb": "^18.0.0",
"eslint-config-prettier": "^6.0.0",
"eslint-plugin-babel": "^5.3.0",
"eslint-plugin-import": "^2.17.3",
"eslint-plugin-import": "~2.18.2",
Copy link
Member Author

@afc163 afc163 Dec 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eslint-plugin-import@2.19.0 breaks npm run lint

@afc163 afc163 merged commit 13fb839 into master Dec 9, 2019
36 checks passed
@afc163 afc163 deleted the fix-icon-component-ts branch Dec 9, 2019
@afc163 afc163 mentioned this pull request Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant