Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using the render property to customize the title, the title prop… #20144

Merged
merged 1 commit into from Dec 9, 2019
Merged

When using the render property to customize the title, the title prop… #20144

merged 1 commit into from Dec 9, 2019

Conversation

mraiguo
Copy link
Contributor

@mraiguo mraiguo commented Dec 9, 2019

…erty of the datasource is not required

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

💡 Background and solution

使用render属性自定义title的时候,可以不需要dataSource里面的title属性。但是不写的话现在的ts定义会报错

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Dec 9, 2019

Deploy preview for ant-design ready!

Built with commit 1451b4b

https://deploy-preview-20144--ant-design.netlify.com

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 9, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1451b4b:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Dec 9, 2019

Codecov Report

Merging #20144 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #20144   +/-   ##
=======================================
  Coverage   97.81%   97.81%           
=======================================
  Files         286      286           
  Lines        7739     7739           
  Branches     2132     2180   +48     
=======================================
  Hits         7570     7570           
  Misses        169      169
Impacted Files Coverage Δ
components/transfer/index.tsx 98.75% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57cb4a4...1451b4b. Read the comment docs.

@afc163 afc163 merged commit 8188956 into ant-design:master Dec 9, 2019
26 of 27 checks passed
@afc163 afc163 mentioned this pull request Dec 10, 2019
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants