Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: less variables for cascader, dropdown, and select #20156

Merged
merged 1 commit into from Dec 10, 2019

Conversation

@Satloff
Copy link
Contributor

Satloff commented Dec 10, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃挕 Background and solution

dropdown, cascader, and Select are all visually similar components, yet have different less variables. I added 4 new variables to cascader and select to keep the customizability up to date with dropdown. 1 new variable to dropdown to increase flexibility.

Dropdown

@dropdown-edge-child-vertical-padding
Edge Child Padding

Select

@select-dropdown-vertical-padding
@select-dropdown-edge-child-vertical-padding
@select-dropdown-font-size: @dropdown-font-size
@select-dropdown-line-height: @dropdown-line-height

Cascader

@cascader-dropdown-vertical-padding
@cascader-dropdown-edge-child-vertical-padding
@cascader-dropdown-font-size
@cascader-dropdown-line-height

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English Cascader, Dropdown, and Select line-height and top/bottom padding less variables
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@auto-add-label auto-add-label bot added the style label Dec 10, 2019
@pr-triage pr-triage bot added the PR: unreviewed label Dec 10, 2019
@netlify

This comment has been minimized.

Copy link

netlify bot commented Dec 10, 2019

Deploy preview for ant-design ready!

Built with commit 51d66b2

https://deploy-preview-20156--ant-design.netlify.com

@codesandbox

This comment has been minimized.

Copy link

codesandbox bot commented Dec 10, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 51d66b2:

Sandbox Source
antd reproduction template Configuration
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 10, 2019

Codecov Report

Merging #20156 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #20156   +/-   ##
=======================================
  Coverage   97.81%   97.81%           
=======================================
  Files         286      286           
  Lines        7739     7739           
  Branches     2132     2177   +45     
=======================================
  Hits         7570     7570           
  Misses        169      169

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 2f7998c...51d66b2. Read the comment docs.

@Satloff Satloff force-pushed the Satloff:sync-dropdowns branch from 3f7b0ce to 51d66b2 Dec 10, 2019
@afc163 afc163 merged commit 721d8cb into ant-design:master Dec 10, 2019
26 checks passed
26 checks passed
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 217 new files uploaded
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
ci/codesandbox Building packages succeeded.
Details
codecov/patch Coverage not affected when comparing 2f7998c...51d66b2
Details
codecov/project 97.81% remains the same compared to 2f7998c
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.