Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Overlapping graphics with two icons in form elements #20164

Merged
merged 1 commit into from Dec 10, 2019

Conversation

@Satloff
Copy link
Contributor

Satloff commented Dec 10, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

#4431

馃挕 Background and solution

This addresses the issue raised in #4431. Now that we can change the @form-component-height we need to calculate the proper spacing between the two icons. This maintains the correct spacing even as the component height grows.

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English Fixes #4431. Adds correct spacing between two icons in form elements.
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@pr-triage pr-triage bot added the PR: unreviewed label Dec 10, 2019
@auto-add-label auto-add-label bot added the bug label Dec 10, 2019
@netlify

This comment has been minimized.

Copy link

netlify bot commented Dec 10, 2019

Deploy preview for ant-design ready!

Built with commit 5d813ba

https://deploy-preview-20164--ant-design.netlify.com

@codesandbox

This comment has been minimized.

Copy link

codesandbox bot commented Dec 10, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5d813ba:

Sandbox Source
antd reproduction template Configuration
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 10, 2019

Codecov Report

Merging #20164 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #20164   +/-   ##
=======================================
  Coverage   97.81%   97.81%           
=======================================
  Files         286      286           
  Lines        7739     7739           
  Branches     2177     2177           
=======================================
  Hits         7570     7570           
  Misses        169      169

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 20ef1f1...5d813ba. Read the comment docs.

@afc163 afc163 merged commit b0d55c8 into ant-design:master Dec 10, 2019
27 checks passed
27 checks passed
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 217 new files uploaded
Details
DEP All dependencies are resolved
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
ci/codesandbox Building packages succeeded.
Details
codecov/patch Coverage not affected when comparing 20ef1f1...5d813ba
Details
codecov/project 97.81% remains the same compared to 20ef1f1
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No new issues
Details
@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.