Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix type of OptionProps #20190

Merged
merged 1 commit into from Dec 11, 2019
Merged

fix: fix type of OptionProps #20190

merged 1 commit into from Dec 11, 2019

Conversation

@ZhechenLi
Copy link
Contributor

ZhechenLi commented Dec 11, 2019

[x] Bug fix
rc-select#Option could accept "label" props, but it was lose in type def OptionProps

https://github.com/react-component/select/blob/9ad3b02c82177db36d8e73f432192f34b9e04e17/src/interface/index.ts#L11

rc-select�#Option could accept "label" props, but it was lose in type def OptionProps
https://github.com/react-component/select/blob/9ad3b02c82177db36d8e73f432192f34b9e04e17/src/interface/index.ts#L11
@auto-add-label auto-add-label bot added the bug label Dec 11, 2019
@pr-triage pr-triage bot added the PR: unreviewed label Dec 11, 2019
@netlify

This comment has been minimized.

Copy link

netlify bot commented Dec 11, 2019

Deploy preview for ant-design ready!

Built with commit 094d493

https://deploy-preview-20190--ant-design.netlify.com

@codesandbox

This comment has been minimized.

Copy link

codesandbox bot commented Dec 11, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 094d493:

Sandbox Source
antd reproduction template Configuration
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 11, 2019

Codecov Report

Merging #20190 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #20190   +/-   ##
=======================================
  Coverage   97.81%   97.81%           
=======================================
  Files         286      286           
  Lines        7739     7739           
  Branches     2177     2177           
=======================================
  Hits         7570     7570           
  Misses        169      169
Impacted Files Coverage Δ
components/select/index.tsx 96.92% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdc6070...094d493. Read the comment docs.

@afc163 afc163 merged commit 6301c20 into ant-design:master Dec 11, 2019
27 checks passed
27 checks passed
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 218 new files uploaded
Details
DEP All dependencies are resolved
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
ci/codesandbox Building packages succeeded.
Details
codecov/patch Coverage not affected when comparing fdc6070...094d493
Details
codecov/project 97.81% remains the same compared to fdc6070
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.