Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/add warning for icon props #20226

Merged
merged 1 commit into from Dec 13, 2019
Merged

Conversation

vagusX
Copy link
Member

@vagusX vagusX commented Dec 12, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

related to ant-design/codemod-v4#5

💡 Background and solution

add some warning for string naming icon props in component Avatar, Button, Modal.method and Result

📝 Changelog

Language Changelog
🇺🇸 English add warning for string naming icon props in component Avatar, Button, Modal.method and Result
🇨🇳 Chinese 给使用字符串作为 icon props 的四个组件(Avatar, Button, Modal.method and Result) 增加 warning

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered README.md
View rendered components/affix/index.en-US.md
View rendered components/affix/index.zh-CN.md
View rendered components/alert/demo/custom-icon.md
View rendered components/alert/demo/error-boundary.md
View rendered components/alert/index.en-US.md
View rendered components/alert/index.zh-CN.md
View rendered components/anchor/index.en-US.md
View rendered components/anchor/index.zh-CN.md

@vagusX vagusX requested a review from zombieJ as a code owner Dec 12, 2019
@auto-add-label auto-add-label bot added the WIP label Dec 12, 2019
@netlify
Copy link

@netlify netlify bot commented Dec 12, 2019

Deploy preview for ant-design ready!

Built with commit 7dadeed

https://deploy-preview-20226--ant-design.netlify.com

@vagusX vagusX changed the base branch from master to 4.0-prepare Dec 12, 2019
@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Dec 12, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7dadeed:

Sandbox Source
antd reproduction template Configuration

@vagusX vagusX changed the title WIP: feat/add warning for icon props feat/add warning for icon props Dec 12, 2019
@vagusX vagusX force-pushed the feat/add-warning-for-icon-props branch from 3310710 to 10a39ef Compare Dec 12, 2019
@vagusX vagusX force-pushed the feat/add-warning-for-icon-props branch from 10a39ef to 7dadeed Compare Dec 12, 2019
@codecov
Copy link

@codecov codecov bot commented Dec 12, 2019

Codecov Report

Merging #20226 into 4.0-prepare will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           4.0-prepare   #20226      +/-   ##
===============================================
+ Coverage        97.55%   97.55%   +<.01%     
===============================================
  Files              294      294              
  Lines             6831     6839       +8     
  Branches          1874     1839      -35     
===============================================
+ Hits              6664     6672       +8     
  Misses             167      167
Impacted Files Coverage Δ
components/result/index.tsx 100% <100%> (ø) ⬆️
components/modal/confirm.tsx 94.54% <100%> (+0.2%) ⬆️
components/button/button.tsx 100% <100%> (ø) ⬆️
components/avatar/index.tsx 98.43% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92e5107...7dadeed. Read the comment docs.

@zombieJ zombieJ merged commit 871ab3d into 4.0-prepare Dec 13, 2019
30 checks passed
@zombieJ zombieJ deleted the feat/add-warning-for-icon-props branch Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants